Skip to content

fix(api-service): E2E improvements #7461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jan 10, 2025
Merged

fix(api-service): E2E improvements #7461

merged 20 commits into from
Jan 10, 2025

Conversation

SokratisVidros
Copy link
Contributor

What changed? Why was the change needed?

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for dev-web-novu ready!

Name Link
🔨 Latest commit d4c6fa4
🔍 Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/6781a0455f3bc20008626133
😎 Deploy Preview https://deploy-preview-7461.dashboard.novu-staging.co
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for dashboard-v2-novu-staging ready!

Name Link
🔨 Latest commit d4c6fa4
🔍 Latest deploy log https://app.netlify.com/sites/dashboard-v2-novu-staging/deploys/6781a04586d3e90008b39d3b
😎 Deploy Preview https://deploy-preview-7461.dashboard-v2.novu-staging.co
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SokratisVidros SokratisVidros marked this pull request as draft January 8, 2025 14:39
@SokratisVidros SokratisVidros changed the title Update .source fix(ci): Restore API E2E Jan 8, 2025
@SokratisVidros SokratisVidros changed the title fix(ci): Restore API E2E fix(api): Restore API E2E Jan 8, 2025
@SokratisVidros SokratisVidros marked this pull request as ready for review January 8, 2025 22:34
@SokratisVidros SokratisVidros requested review from a team and merrcury and removed request for a team January 8, 2025 22:34
@SokratisVidros SokratisVidros changed the title fix(api): Restore API E2E fix(api-service): Restore API E2E Jan 8, 2025
@SokratisVidros SokratisVidros force-pushed the fix_api_e2e branch 2 times, most recently from 31ea007 to 91fb87f Compare January 9, 2025 12:48
@SokratisVidros SokratisVidros changed the title fix(api-service): Restore API E2E fix(api-service): Refactor API E2E Jan 9, 2025
@SokratisVidros SokratisVidros changed the title fix(api-service): Refactor API E2E fix(api-service): E2E improvements Jan 9, 2025
@@ -11,268 +11,14 @@ on:
workflow_dispatch:

jobs:
dependency-review:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous steps will be restored as soon as all tests are green.

@@ -59,7 +59,7 @@ contexts.forEach((context: Context) => {
await bridgeServer.stop();
});

it(`should trigger the bridge workflow with sync [${context.name}]`, async () => {
it.only(`should trigger the bridge workflow with sync [${context.name}]`, async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only to be removed

@SokratisVidros SokratisVidros merged commit fbc1c2e into next Jan 10, 2025
35 of 37 checks passed
@SokratisVidros SokratisVidros deleted the fix_api_e2e branch January 10, 2025 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants