feat(framework): add fetchOptions parameter to Client for custom fetch configuration
#7433
+23
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fetch configuration close novuhq#7432
👷 Deploy request for dev-web-novu pending review.Visit the deploys page to approve it
|
👷 Deploy request for dashboard-v2-novu-staging pending review.Visit the deploys page to approve it
|
SokratisVidros
requested changes
Jan 7, 2025
| * Additional fetch options to be passed to the fetch API. | ||
| * This can be used to set custom agent, headers, etc. | ||
| */ | ||
| fetchOptions?: Record<string, any>; |
There was a problem hiding this comment.
To provide better DX, I suggest typing this as a RequestInit.
|
Thanks for the contribution! Let's address the latest comment before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
As a developer based in China, I often face issues with accessing Novu’s services due to the Great Firewall (GFW). This leads to timeouts when my local services attempt to send requests to Novu’s servers. Adding fetchOptions would allow me to use tools like https-proxy-agent to bypass these restrictions by routing requests through a proxy server.
close #7432