feat(api-service): Usage insights email #7346
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LaunchDarkly flag references🔍 1 flag added or modified
|
scopsy
commented
Dec 22, 2024
| @@ -24,7 +24,7 @@ export const getBridgeUrl = async (): Promise<string> => { | |||
|
|
|||
| // Local environments | |||
| try { | |||
| if (process.env.NODE_ENV === 'development') { | |||
| if (process.env.NODE_ENV === 'development' || process.env.NODE_ENV === 'local') { | |||
There was a problem hiding this comment.
Allow passing the well known also for the local environment not only dev
@novu/client
@novu/headless
@novu/framework
@novu/node
@novu/notification-center
novu
@novu/providers
@novu/shared
commit: |
scopsy
changed the title
scopsy
requested review from
BiswaViraj,
LetItRock,
ChmaraX and
SokratisVidros
and removed request for
BiswaViraj
scopsy
commented
Jan 21, 2025
| } from '../types/usage-insights.types'; | ||
|
|
||
| @Injectable() | ||
| export class MetricsCalculatorService { |
There was a problem hiding this comment.
This service is normalizing the mixpanel data structure to our own dto
scopsy
commented
Jan 21, 2025
| import { join } from 'path'; | ||
| import { IMixpanelInboxResponse, IMixpanelTriggerResponse } from '../types/usage-insights.types'; | ||
|
|
||
| const USE_INSIGHTS_CACHE = process.env.USE_INSIGHTS_CACHE === 'true'; |
There was a problem hiding this comment.
Caching is used locally for development to avoid rate limits
scopsy
commented
Jan 21, 2025
| @@ -0,0 +1,117 @@ | |||
| import { ChannelTypeEnum } from '@novu/shared'; | |||
|
|
|||
| export enum MixpanelTriggerEventNameEnum { | |||
There was a problem hiding this comment.
Types for mixpanel API response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Rollout plan
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer