-
Notifications
You must be signed in to change notification settings - Fork 111
Update content for Pusher beams provider guide #991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
❌ Deploy Preview for docs-novu failed. Why did it fail? →
|
WalkthroughThe Pusher Beams integration documentation has been substantially rewritten with expanded content, restructured sections, improved step-by-step setup guidance, new subsections, updated code examples, and enhanced API references. The import line was replaced with a static HTML anchor. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Documentation rewrites are generally low-complexity reviews when focusing on content clarity, accuracy, and consistency rather than logic. This change maintains existing code blocks while restructuring and expanding narrative content and setup guidance. Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
content/docs/platform/integrations/push/(providers)/pusher-beams.mdx (2)
111-112: Clarify payload restrictions for external SDK users.The inline comment about the
"pusher"key restriction in the notification payload is valuable but somewhat buried. Consider making this a note or callout block to ensure users don't miss this important constraint when structuring their custom data.
49-88: Example device token formats should be normalized for clarity.The code is correct:
ChatOrPushProviderEnum.PusherBeamsproperly maps to"pusher-beams"in both examples. However, the device token examples are inconsistent—Node.js uses generic["token1", "token2", "token3"]while cURL shows a single token labeled['userId-from-pusher-beams']. To improve clarity, either use consistent generic placeholders across both examples or add inline comments explaining what actual tokens should replace these placeholders.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (3)
public/images/channels-and-providers/push/pusher-beams/create-instance.pngis excluded by!**/*.pngpublic/images/channels-and-providers/push/pusher-beams/instance-credentials.pngis excluded by!**/*.pngpublic/images/channels-and-providers/push/pusher-beams/pusher-beams-integration.pngis excluded by!**/*.png
📒 Files selected for processing (1)
content/docs/platform/integrations/push/(providers)/pusher-beams.mdx(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Redirect rules - docs-novu
- GitHub Check: Header rules - docs-novu
- GitHub Check: Pages changed - docs-novu
- GitHub Check: Build and Lint
🔇 Additional comments (4)
content/docs/platform/integrations/push/(providers)/pusher-beams.mdx (4)
6-8: Good documentation structure with helpful setup guidance.The introduction clearly frames the guide scope, uses proper external link security attributes (
target="_blank" rel="noopener noreferrer"), and establishes what readers will accomplish. The section headings and flow from configuration → usage is well-organized.
6-6: All external links use proper security attributes.The documentation consistently uses
target="_blank" rel="noopener noreferrer"for external links (Pusher SDK setup, getUserId method, dashboard links). This follows security best practices.Also applies to: 43-43, 45-45
18-23: All image assets and cross-reference links are valid—no action required.Both referenced images exist at the correct paths, and the anchor link
#step-2-connect-pusher-beams-to-novucorrectly matches the heading format on line 25.
47-47: All internal documentation links are valid and accessible.The API reference link at line 47 (
/api-reference/subscribers/update-provider-credentials) correctly points to an existing file, and the internal anchor at line 22 (#step-2-connect-pusher-beams-to-novu) maps to the "Step 2: Connect Pusher Beams to Novu" heading in the document. No broken or missing links detected.
Summary by CodeRabbit