Skip to content

chore: regenerate API client from latest OpenAPI spec - #109

Open
giordano-lucas wants to merge 1 commit into
mainfrom
chore/regenerate-api-client
Open

giordano-lucas wants to merge 1 commit into
mainfrom
chore/regenerate-api-client

Conversation

@giordano-lucas

Copy link
Copy Markdown
Member

Automated regeneration of the generated API client (internal/api, internal/cmd/*_flags.gen.go) from the latest OpenAPI spec.

Last regenerated: 2026-09-14 14:23 UTC

@andreakiro andreakiro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved: scheduled API client regeneration.

@greptile-apps

greptile-apps Bot commented Sep 14, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 4/5

The PR is not safe to merge until session start honors the documented authentication-wait preference and the explicit testing requirement is addressed.

Fix All in Claude CodeFindings

  1. P1 Authentication Wait Is Ignored
Fix with agent prompt
### Issue 1
internal/cmd/sessionstart_flags.gen.go:93
When Managed Auth requires background login, the API can return a session with status `authenticating`. Although this flag now says that SDKs implement waiting through readiness polling, the session-start command stores and prints the response without checking its status or polling the new readiness endpoint. As a result, the default behavior and `--wait-for-authentication` can return a session before authentication completes, leaving callers with a session that is not ready to use.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

  • Adds Managed Auth operation/readiness models and status enums.
  • Adds GET /sessions/{session_id}/auth request and response support.
  • Adds auth_retry fields and the --auth-retry CLI flag.
  • Updates session status and authentication-waiting semantics.
  • The CLI does not yet implement the readiness polling required by the new waiting contract.

Reviews (1) · Last reviewed commit: "chore: regenerate API client from latest..."

cmd.Flags().IntVar(&SessionStartViewportHeight, "viewport-height", 0, "The height of the viewport")
cmd.Flags().IntVar(&SessionStartViewportWidth, "viewport-width", 0, "The width of the viewport")
cmd.Flags().BoolVar(&SessionStartWaitForAuthentication, "wait-for-authentication", false, "Whether to wait for Managed Auth profile restoration and authentication before returning the session. When false, authentication continues in the background after the browser is ready. (API default: true)")
cmd.Flags().BoolVar(&SessionStartWaitForAuthentication, "wait-for-authentication", false, "SDK waiting preference. The API always verifies inline and returns authenticating when background login is needed; SDKs implement waiting through readiness polling. (API default: true)")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Authentication Wait Is Ignored

When Managed Auth requires background login, the API can return a session with status authenticating. Although this flag now says that SDKs implement waiting through readiness polling, the session-start command stores and prints the response without checking its status or polling the new readiness endpoint. As a result, the default behavior and --wait-for-authentication can return a session before authentication completes, leaving callers with a session that is not ready to use.

Prompt To Fix With AI
This is a comment left during a code review.
Path: internal/cmd/sessionstart_flags.gen.go
Line: 93

Comment:
**Authentication Wait Is Ignored**

When Managed Auth requires background login, the API can return a session with status `authenticating`. Although this flag now says that SDKs implement waiting through readiness polling, the session-start command stores and prints the response without checking its status or polling the new readiness endpoint. As a result, the default behavior and `--wait-for-authentication` can return a session before authentication completes, leaving callers with a session that is not ready to use.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Fix in Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants