chore: regenerate API client from latest OpenAPI spec - #109
giordano-lucas wants to merge 1 commit into
Conversation
andreakiro
left a comment
There was a problem hiding this comment.
Auto-approved: scheduled API client regeneration.
|
| cmd.Flags().IntVar(&SessionStartViewportHeight, "viewport-height", 0, "The height of the viewport") | ||
| cmd.Flags().IntVar(&SessionStartViewportWidth, "viewport-width", 0, "The width of the viewport") | ||
| cmd.Flags().BoolVar(&SessionStartWaitForAuthentication, "wait-for-authentication", false, "Whether to wait for Managed Auth profile restoration and authentication before returning the session. When false, authentication continues in the background after the browser is ready. (API default: true)") | ||
| cmd.Flags().BoolVar(&SessionStartWaitForAuthentication, "wait-for-authentication", false, "SDK waiting preference. The API always verifies inline and returns authenticating when background login is needed; SDKs implement waiting through readiness polling. (API default: true)") |
There was a problem hiding this comment.
Authentication Wait Is Ignored
When Managed Auth requires background login, the API can return a session with status authenticating. Although this flag now says that SDKs implement waiting through readiness polling, the session-start command stores and prints the response without checking its status or polling the new readiness endpoint. As a result, the default behavior and --wait-for-authentication can return a session before authentication completes, leaving callers with a session that is not ready to use.
Prompt To Fix With AI
This is a comment left during a code review.
Path: internal/cmd/sessionstart_flags.gen.go
Line: 93
Comment:
**Authentication Wait Is Ignored**
When Managed Auth requires background login, the API can return a session with status `authenticating`. Although this flag now says that SDKs implement waiting through readiness polling, the session-start command stores and prints the response without checking its status or polling the new readiness endpoint. As a result, the default behavior and `--wait-for-authentication` can return a session before authentication completes, leaving callers with a session that is not ready to use.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Automated regeneration of the generated API client (
internal/api,internal/cmd/*_flags.gen.go) from the latest OpenAPI spec.Last regenerated: 2026-09-14 14:23 UTC