Skip to content

Better images #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

Better images #46

wants to merge 11 commits into from

Conversation

jehendeoff
Copy link
Contributor

@jehendeoff jehendeoff commented Jun 19, 2023 •
edited
Loading

Here's a list that I want to change

  • center the images
  • handle multiple images in the folder (slideshow feature)
  • Filter through every known image type (eg. let's not try to open a .odt file)
  • have "animations" when changing images
  • smash all the (image related) TODOs

Bonus

  • Optimisations :
    • The resize algorithm is handled by the image crate itself
    • Won't apply the slideshow logic if there is only 1 image

@not-jan not-jan marked this pull request as draft April 16, 2024 15:09
@SalahAdDin

This comment was marked as spam.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jehendeoff @SalahAdDin