[mayuriphad]

Fixes #4236

_check_matcher compared a naive datetime.now() against Matcher.expire_time. When expire_time is a timezone-aware datetime (allowed by the datetime | timedelta annotation, e.g. datetime.now(timezone.utc) + timedelta(minutes=5)), the comparison raises TypeError: can't compare offset-naive and offset-aware datetimes outside the permission/rule try blocks. The matcher is then never destroyed and keeps failing on every event.

This takes "now" in the expire time's own timezone: datetime.now(Matcher.expire_time.tzinfo). For naive expire_time (including the timedelta path, which produces a naive datetime) tzinfo is None, so behaviour is unchanged.

Added test_aware_datetime_expire, mirroring test_datetime_expire with an already expired UTC-aware expire_time, and checked that the matcher gets destroyed.

ruff format --check and ruff check pass on the changed files. I have not run the pytest suite locally; relying on CI for it.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

[github-actions]

🚀 Deployed to https://deploy-preview-4237--nonebot2.netlify.app

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.85%. Comparing base (8ea99f1) to head (37ffbc5).
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4237      +/-   ##
==========================================
+ Coverage   93.84%   93.85%   +0.01%     
==========================================
  Files          49       49              
  Lines        4532     4540       +8     
==========================================
+ Hits         4253     4261       +8     
  Misses        279      279              

Flag	Coverage Δ
unittests	93.85% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

🟡 Changes recommended

The expiry comparison can prematurely destroy matchers during a DST rollback because datetimes sharing a tzinfo object are compared by wall-clock fields rather than actual instants.

1 open issue

• Compare aware datetimes by instant to handle DST folds · New

_{Review effort: Balanced}