Skip to content

Refactor cwmp and configuration#15

Open
mptrk wants to merge 6 commits into
mainfrom
refactor-cwmp
Open

Refactor cwmp and configuration#15
mptrk wants to merge 6 commits into
mainfrom
refactor-cwmp

Conversation

@mptrk
Copy link
Copy Markdown
Collaborator

@mptrk mptrk commented May 10, 2026

  • Remove artifact automatic selection and parsing; user can either specify one explicitly or select if more than one found and none was explicitly specified.
  • Rewrite CWMP SOAP message handling to use typed encoding/xml envelopes and RPC structs, including support for GetRPCMethods and async RPC flows.
  • Replace the old dispatcher-driven flow with a generic device executor model and move CWMP/SSH implementations into protocol-specific packages.
  • Rework sequence execution to be protocol-agnostic with per-step timeouts, retries, delays, ignore-failure behavior, and response capture.
  • Add typed endpoint/auth configuration and update tests to cover the new message and device structure.
  • Simplify publish sequences using the typed endpoint configurations.
  • Cleanup

mptrk added 4 commits May 10, 2026 22:41
Signed-off-by: Manolis Paterakis <manolis.paterakis@nokia.com>
- Rewrite CWMP SOAP message handling to use typed encoding/xml envelopes
  and RPC structs, including support for GetRPCMethods and async RPC
  flows.
- Replace the old dispatcher-driven flow with a generic device executor
  model and move CWMP/SSH implementations into protocol-specific
  packages.
- Rework sequence execution to be protocol-agnostic with per-step
  timeouts, retries, delays, ignore-failure behavior, and response
  capture.
- Add typed endpoint/auth configuration and update tests to cover
  the new message and device structure.
@mptrk mptrk requested a review from panpipis May 10, 2026 20:02
@mptrk mptrk self-assigned this May 10, 2026
@aegagros aegagros added this to the v33.0.0 release milestone May 11, 2026
@mptrk mptrk added the bug Something isn't working label May 15, 2026
@mptrk
Copy link
Copy Markdown
Collaborator Author

mptrk commented May 15, 2026

There is a segfault when publishing with a predefined artifact, using --artifact option. See below:

$ corteca publish local --artifact ./dist/TestApp-0.0.1-aarch64-oci.tar
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x38 pc=0x9946b2]

goroutine 1 [running]:
github.com/nokia/corteca-cli/cmd.requireBuildArtifact()
	/home/pateraki/Projects/bbd/foss/corteca-cli/cmd/root.go:231 +0x1f2
github.com/nokia/corteca-cli/cmd.doPublishApp({0x7ffdada4500f, 0x5}, 0x1)
	/home/pateraki/Projects/bbd/foss/corteca-cli/cmd/publish.go:59 +0x36
github.com/nokia/corteca-cli/cmd.init.func6(0x9a5c775cf00?, {0x9a5c77b2240?, 0x4?, 0xb4f00e?})
	/home/pateraki/Projects/bbd/foss/corteca-cli/cmd/publish.go:39 +0x29
github.com/spf13/cobra.(*Command).execute(0x114f120, {0x9a5c77b21e0, 0x3, 0x3})
	/home/pateraki/go/pkg/mod/github.com/spf13/cobra@v1.7.0/command.go:944 +0x89b
github.com/spf13/cobra.(*Command).ExecuteC(0x114fca0)
	/home/pateraki/go/pkg/mod/github.com/spf13/cobra@v1.7.0/command.go:1068 +0x398
github.com/spf13/cobra.(*Command).Execute(...)
	/home/pateraki/go/pkg/mod/github.com/spf13/cobra@v1.7.0/command.go:992
github.com/nokia/corteca-cli/cmd.Execute(...)
	/home/pateraki/Projects/bbd/foss/corteca-cli/cmd/root.go:77
main.main()
	/home/pateraki/Projects/bbd/foss/corteca-cli/main.go:10 +0x1b

Comment thread internal/configuration/sequence.go Outdated
mptrk and others added 2 commits May 21, 2026 00:40
@mptrk mptrk removed the bug Something isn't working label May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants