sync experiment #5
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Pyroscope Bot <[email protected]>
They are failing since some time and we are planning to migrate to ebpf-profiler from open-telemetry.
Just to see if I understood it well :)
* chore: Update otel to latest versions This carries a lot of other upgrade to dependcies along with it. It tried to sync all the code generation versions in Makefile with the updated go modules in go.mod. I also had to switch the minimum version in go.mod from 1.22 to 1.22.0 (because that's what otel does). * Handle empty location index * Remove tool chains * And another one
Co-authored-by: Pyroscope Bot <[email protected]>
* chore: bump to go1.23 & address CVE-2025-22868
* cypress: test check * bump cypress to 13.0.0 * Revert "cypress: test check" This reverts commit 54cf8a7.
) * go get golang.org/x/[email protected] and go mod tidy on go.mod * go get golang.org/x/[email protected] and go mod tidy on ebpf/go.mod * go get golang.org/x/[email protected] and go mod tidy on api/go.mod
…4039) Bumps [github.com/golang-jwt/jwt/v5](https://github.com/golang-jwt/jwt) from 5.2.1 to 5.2.2. - [Release notes](https://github.com/golang-jwt/jwt/releases) - [Changelog](https://github.com/golang-jwt/jwt/blob/main/VERSION_HISTORY.md) - [Commits](golang-jwt/jwt@v5.2.1...v5.2.2) --- updated-dependencies: - dependency-name: github.com/golang-jwt/jwt/v5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Use default size constant for initializing tree in benchmark Refactor the benchmark for `*stacktraceTree.insert` to use the constant for default tree size instead of hard-coding 0. This will become useful in future changes. * Add benchmark for `*stacktraceTree.insert` with different init sizes This benchmark can be slow, thus it won't run unless the `COMPARE_STACKTRACETREE_INSERT_DEFAULT_SIZES` environment variable is set to true. In addition, if the `-v` flag is passed to `go test` it will print the initial and max tree size after inserting all the samples from the test profile. * Remove commented out line * Always run stacktraceTree default size benchmark * Use b.ReportMetric instead of b.Log We could revisit if we want to always show these values, and if we want to add/remove columns.
Co-authored-by: Pyroscope Bot <[email protected]>
In the error case the time window might already have been removed by the time the aggreagtion after the first error occours. I ammended the test, that it accepts either outcome of the following aggreagtions. But it also makes sure the aggreagtion eventually recovers.
Our validation has been overly strict, since inception of the project. Although we failed to call the validate alltogether. This was fixed in This PR loosens the criteria accordingly Fixes #3968
* chore(deps): bump @babel/runtime from 7.22.6 to 7.26.10 Bumps [@babel/runtime](https://github.com/babel/babel/tree/HEAD/packages/babel-runtime) from 7.22.6 to 7.26.10. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.26.10/packages/babel-runtime) --- updated-dependencies: - dependency-name: "@babel/runtime" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * Update to nodejs v20 --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Christian Simon <[email protected]>
* feat: Align missing service_name behaviour with otel spec When looking at otel-ebpf-profiler I noticed we ignored their specification: https://github.com/open-telemetry/opentelemetry-go/blob/ecfb73581f1b05af85fc393c3ce996a90cf2a5e2/semconv/v1.30.0/attribute_group.go#L10011-L10025 * Fix integration test * More integration * Make more use of constants
* chore: Update @pyroscope/node-js * Fix teardown
* feat: Add Prometheus to the rideshare demo w/utf_8 (#4011) --------- Co-authored-by: Marc Mignonsin <[email protected]> Co-authored-by: Christian Simon <[email protected]> Co-authored-by: pyroscope-development-app[bot] <191832211+pyroscope-development-app[bot]@users.noreply.github.com> Co-authored-by: Pyroscope Bot <[email protected]>
Co-authored-by: Pyroscope Bot <[email protected]>
Not too sure what those packages do, but hopefully they still compile/work :)
…ntation/ruby/rideshare (#4306) * chore(deps): bump sinatra and thin Bumps [sinatra](https://github.com/sinatra/sinatra) and [thin](https://github.com/macournoyer/thin). These dependencies needed to be updated together. Updates `sinatra` from 2.2.4 to 4.1.1 - [Changelog](https://github.com/sinatra/sinatra/blob/main/CHANGELOG.md) - [Commits](sinatra/sinatra@v2.2.4...v4.1.1) Updates `thin` from 1.8.2 to 2.0.1 - [Release notes](https://github.com/macournoyer/thin/releases) - [Changelog](https://github.com/macournoyer/thin/blob/master/CHANGELOG) - [Commits](macournoyer/thin@v1.8.2...v2.0.1) --- updated-dependencies: - dependency-name: sinatra dependency-version: 4.1.1 dependency-type: direct:production - dependency-name: thin dependency-version: 2.0.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * Fix ruby examples --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Christian Simon <[email protected]>
* chore: upgrade dskit * Fix tests * Bump prometheus as well * Make change more consistent * Add go build flag to a few more places * Remove build tag, cleanup dependencies * Tidy up some more * Add route injector middleware * Add missing route matcher * Fix flaky test * Bump again after rebase
…na (#4292) * fix: make ingress PathType configurable via `values.yaml` * Run code generate `make helm/check helm/docs` --------- Co-authored-by: Christian Simon <[email protected]>
Co-authored-by: Pyroscope Bot <[email protected]>
When the cookie contains valid base64 in json, with an empty token field. We return a nil token and eat the innerError, which leads to nil pointer exception down the line.
This was added to store Alloy config related to Profile collection. These settings were only stored there for a very brief moment and no main commit or released version of the Profiles Drilldown app every relied on it. This clears up everything and will leave no trace. This is okay as the feature was marked as experimental
* Add frame pointers needed for additional ebpf langs * Make ebpf supported languages content shared and in new places
The use of oauth2-proxy just for nonce handling is total overkill. Given there is a critical vulnerablility in oauth2-proxy, that will be flagged I rather remove it at this point.
* Improve distributor sampling rule evaluation * Improve wording * Switch to strings.Contains and add test
…4352) * Add doc for finding URL, pw, user in Cloud Profiles * Apply suggestions from code review Co-authored-by: Bryan Huhta <[email protected]> --------- Co-authored-by: Bryan Huhta <[email protected]>
* chore: Update cypress to latest version * Set the locale for cypress * Locale messing about * Now with sudo * more tries * clean up
Added section describing pyperf error when Python libraries have custom names
* fix broken pprof split when using relabel.LabelDrop * Add benchmark * Add test
Bumps [tmp](https://github.com/raszi/node-tmp) from 0.2.1 to 0.2.4. - [Changelog](https://github.com/raszi/node-tmp/blob/master/CHANGELOG.md) - [Commits](raszi/node-tmp@v0.2.1...v0.2.4) --- updated-dependencies: - dependency-name: tmp dependency-version: 0.2.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Update setup-linux.md * Update docs/sources/configure-client/grafana-alloy/ebpf/setup-linux.md * Update setup-linux.md Change refs to links. --------- Co-authored-by: Kim Nylander <[email protected]>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
* feat: annotate sampled profiles * Update pkg/distributor/annotation/throttling.go Co-authored-by: Tolya Korniltsev <[email protected]> --------- Co-authored-by: Tolya Korniltsev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NO MERGE.
This PR just includes all the changes that we don't have from the original repo for an easier review. cc: @JungMinu @juanarbol
My 2cents so far: