Skip to content

test(fetch): add userinfo coverage for issue-4897 URLs #4901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mcollina wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test(fetch): add userinfo coverage for issue-4897 URLs #4901

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions test/fetch/issue-4897.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,33 @@ async function assertPath (t, url, expectedPath) {
})
}

async function assertCredentialsRejected (t, url) {
const dispatcher = createAssertingDispatcher(t, '/test?a=b')

await t.assert.rejects(fetch(url, { dispatcher }), (err) => {
t.assert.strictEqual(err.name, 'TypeError')
t.assert.match(err.message, /includes credentials/)
return true
})
}

// https://github.com/nodejs/undici/issues/4897
test('fetch path extraction does not match hostnames inside scheme', async (t) => {
const hosts = ['h', 't', 'p', 'ht', 'tp', 'tt']

for (const scheme of ['http', 'https']) {
for (const host of hosts) {
await t.test(`${scheme}://${host}/test?a=b#frag`, async (t) => {
await assertPath(t, `${scheme}://${host}/test?a=b#frag`, '/test?a=b')
})
for (const userinfo of ['', 'user:pass@']) {
for (const host of hosts) {
await t.test(`${scheme}://${userinfo}${host}/test?a=b#frag`, async (t) => {
const url = `${scheme}://${userinfo}${host}/test?a=b#frag`

if (userinfo) {
await assertCredentialsRejected(t, url)
} else {
await assertPath(t, url, '/test?a=b')
}
})
}
}
}
})
Loading