fix: Remove side effect to fix pnpm + vite issue

[haines]

Fixes #110

This PR delays the feature detection of require.resolve until a Hook is created, which avoids an issue where Vite can bundle the module into an ESM context where require is unavailable (vitejs/vite#19403).

[timfish]

Have you tested if this actually fixes the issue with Vite?

[haines]

@timfish yep, I applied this change to our application using pnpm patch and it fixed the issue.

[jsumners-nr]

I don't understand the issue. Why do we need to define a new method on Hook? What is wrong with defining the module local resolve function?

[timfish]

I don't understand the issue.

v7.5.0 added some side-effects and now when using pnpm, vite outputs invalid code. Our existing code is perfectly valid and frankly this really is not our problem, but it's impacting a lot of users and this is a simple change.

Why do we need to define a new method on Hook? What is wrong with defining the module local resolve function?

Yep, that would be better!

[timfish]

@haines can you make these changes to your PR?

I did try to push to your branch but didn't have permissions.

[haines]

@timfish I've refactored it to keep resolve as a module-level function, but do the feature detection lazily to remove the side effect. What do you think?