Skip to content

Comments

nodejs-ko: Translate "download" menu as Korean#857

Merged
1 commit merged intonodejs:masterfrom
outsideris:translate-download-ko
Aug 19, 2016
Merged

nodejs-ko: Translate "download" menu as Korean#857
1 commit merged intonodejs:masterfrom
outsideris:translate-download-ko

Conversation

@outsideris
Copy link
Contributor

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

사용된 화면을 보니 "대다수 사용자에게 추천"으로 해도 될 것 같습니다.
screen shot 2016-08-12 at 13 26 09

@taggon
Copy link
Contributor

taggon commented Aug 12, 2016

I've done my review.

@stevemao stevemao added i18n Issues/PRs related to the Website Internationalisation needs WG +1 labels Aug 12, 2016
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그다음 -> 그 다음 || 그리고

@ghost ghost changed the title Translate "download" menu as Korean nodejs-ko: Translate "download" menu as Korean Aug 16, 2016
@outsideris outsideris force-pushed the translate-download-ko branch from 0a437e1 to 755d338 Compare August 17, 2016 16:48
@outsideris
Copy link
Contributor Author

I updated it as reviews. Please leave +1 if there is no issue or leave reviews if there is some issues.

@marocchino
Copy link
Contributor

👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I missed this one.
This link will not work since The anchors based on h2 tag contents.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marocchino Good point! I fixed anchors.

@outsideris outsideris force-pushed the translate-download-ko branch from 755d338 to 544ae98 Compare August 19, 2016 04:10
@ghost
Copy link

ghost commented Aug 19, 2016

LGTM!

@ghost ghost merged commit 0e8c57b into nodejs:master Aug 19, 2016
* [FreeBSD와 OpenBSD](#freebsd-openbsd)
* [Gentoo](#gentoo)
* [NetBSD](#netbsd)
* [openSUSE와 SLE](#opensuse-and-sle)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: check it later

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Issues/PRs related to the Website Internationalisation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants