Skip to content

Conversation

@avivkeller
Copy link
Member

The @nodejs/releasers team isn't pinged to the release blog post PR until it's ready for review. By cc-ing them in the description, they will be pinged on creation.

@targos does this resolve the concerns you brought up?

Copilot AI review requested due to automatic review settings December 12, 2025 01:41
@avivkeller avivkeller requested a review from a team as a code owner December 12, 2025 01:41
@vercel
Copy link

vercel bot commented Dec 12, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
nodejs-org Ready Ready Preview Dec 12, 2025 8:50pm

@github-actions
Copy link
Contributor

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/web-infra

Please review the changes when you have a chance. Thank you! 🙏

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modifies the GitHub workflow that creates release blog post PRs to include a mention of the @nodejs/releasers team in the PR description. The goal is to notify the releasers team immediately when the PR is created, rather than waiting until it's marked as ready for review.

  • Adds cc @nodejs/releasers to the PR body template in the create-release-post workflow
Comments suppressed due to low confidence (1)

.github/workflows/create-release-post.yml:59

  • The team mention @nodejs/releasers may not trigger notifications because the PR is created as a draft (line 59). GitHub typically does not send notifications for team mentions in draft PRs until they are marked as ready for review. Consider either removing draft: true or using a different notification mechanism if immediate notification on PR creation is required.
            cc @nodejs/releasers

            Check this workflow's logs at ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}.
          commit-message: 'feat(blog): create post for ${{ inputs.version }}'
          labels: fast-track
          title: 'feat(blog): create post for ${{ inputs.version }}'
          draft: true

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.69%. Comparing base (bf98887) to head (b223ca2).
⚠️ Report is 6 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8412      +/-   ##
==========================================
- Coverage   73.71%   73.69%   -0.03%     
==========================================
  Files         107      107              
  Lines        9155     9161       +6     
  Branches      308      311       +3     
==========================================
+ Hits         6749     6751       +2     
- Misses       2404     2408       +4     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MattIPv4
Copy link
Member

Is it possible to assign the PR to the releaser coordinating the release, rather than pinging the entire team? They'll still get pinged once the assigned releaser marks the PR as ready for review.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 12, 2025

📦 Build Size Comparison

Summary

Metric Value
Old Total Size 4.34 MB
New Total Size 4.34 MB
Delta 0 B (0.00%)

Changes

➕ Added Assets (1)
Name Size
.next/static/chunks/10b5bac6309ad4de.js 204.26 KB
➖ Removed Assets (1)
Name Size
.next/static/chunks/fa44b963b824c496.js 204.26 KB

Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@aduh95
Copy link
Contributor

aduh95 commented Dec 12, 2025

Is it possible to assign the PR to the releaser coordinating the release, rather than pinging the entire team? They'll still get pinged once the assigned releaser marks the PR as ready for review.

For reference we do that in create-release-proposal.yml, we pass the GITHUB_ACTOR env variable to the script that opens the PR, which in turn calls gh pr edit "$PR_URL" --add-assignee "$GITHUB_ACTOR"

Copy link
Member

@flakey5 flakey5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending #8412 (comment)

@avivkeller avivkeller force-pushed the ping-releasers-before-ready-for-review branch from 8a4e048 to b223ca2 Compare December 12, 2025 20:49
@avivkeller avivkeller requested a review from a team as a code owner December 12, 2025 20:49
@avivkeller avivkeller added this pull request to the merge queue Dec 13, 2025
Merged via the queue into main with commit 0d0a4a4 Dec 13, 2025
12 checks passed
@avivkeller avivkeller deleted the ping-releasers-before-ready-for-review branch December 13, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants