-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
chore(ci): ping releasers on blog post PR #8412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/web-infra Please review the changes when you have a chance. Thank you! 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR modifies the GitHub workflow that creates release blog post PRs to include a mention of the @nodejs/releasers team in the PR description. The goal is to notify the releasers team immediately when the PR is created, rather than waiting until it's marked as ready for review.
- Adds
cc @nodejs/releasersto the PR body template in the create-release-post workflow
Comments suppressed due to low confidence (1)
.github/workflows/create-release-post.yml:59
- The team mention
@nodejs/releasersmay not trigger notifications because the PR is created as a draft (line 59). GitHub typically does not send notifications for team mentions in draft PRs until they are marked as ready for review. Consider either removingdraft: trueor using a different notification mechanism if immediate notification on PR creation is required.
cc @nodejs/releasers
Check this workflow's logs at ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}.
commit-message: 'feat(blog): create post for ${{ inputs.version }}'
labels: fast-track
title: 'feat(blog): create post for ${{ inputs.version }}'
draft: true
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8412 +/- ##
==========================================
- Coverage 73.71% 73.69% -0.03%
==========================================
Files 107 107
Lines 9155 9161 +6
Branches 308 311 +3
==========================================
+ Hits 6749 6751 +2
- Misses 2404 2408 +4
Partials 2 2 ☔ View full report in Codecov by Sentry. |
|
Is it possible to assign the PR to the releaser coordinating the release, rather than pinging the entire team? They'll still get pinged once the assigned releaser marks the PR as ready for review. |
📦 Build Size ComparisonSummary
Changes➕ Added Assets (1)
➖ Removed Assets (1)
|
targos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
For reference we do that in |
flakey5
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm pending #8412 (comment)
8a4e048 to
b223ca2
Compare
The @nodejs/releasers team isn't pinged to the release blog post PR until it's ready for review. By cc-ing them in the description, they will be pinged on creation.
@targos does this resolve the concerns you brought up?