-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
feat(cicd): automate the creation of blog posts #8231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8231 +/- ##
==========================================
+ Coverage 76.39% 76.52% +0.12%
==========================================
Files 115 117 +2
Lines 9643 9733 +90
Branches 318 330 +12
==========================================
+ Hits 7367 7448 +81
- Misses 2275 2283 +8
- Partials 1 2 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Aviv Keller <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Automate creating release blog posts and opening a PR via GitHub Actions.
- Update the release-post script to return both the file path and metadata so the workflow can capture the version.
- Add a GitHub Actions workflow to run the script and open/update a PR with the new blog post.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
apps/site/scripts/release-post/index.mjs | Adjusts writeToFile to resolve both path and results; logs and emits version for workflow consumption. |
.github/workflows/create-release-post.yml | New workflow to generate a release post and open a PR, using a pinned action and step outputs. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]> Signed-off-by: Aviv Keller <[email protected]>
@RafaelGSS @nodejs/security-wg please review this. |
The passing of an input version is no longer optional, and a draft PR is used in place of requiring a custom token |
@mcollina could you please take another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Just a random idea, maybe we could trigger automatically when a release is created on nodejs/node with https://docs.github.com/en/webhooks/webhook-events-and-payloads#repository_dispatch |
I think that's worth exploring separately from this. Just having this (and being able to manually trigger) would be a good stepping point -- for me creating the blog posts is currently one of the more time consuming parts of the release process on release day (due to needing to switch to a dev environment with pnpm and Husky pre-commit hooks). |
Can this be triggered from https://github.com/nodejs/node/blob/main/.github/workflows/update-release-links.yml, which is the same automation that triggers the release worker to update the files available when a new release is cut? |
That's the plan I had in mind |
@nodejs/web-infra
|
We cannot fix that, new actions need to be added to the repo settings by @ovflowd or @bmuenzenmeyer (I don't see the web-admin team yet) |
added |
cc @nodejs/releasers