Skip to content

Conversation

avivkeller
Copy link
Member

@avivkeller avivkeller commented Oct 15, 2025

cc @nodejs/releasers

@vercel
Copy link

vercel bot commented Oct 15, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Ready Ready Preview Oct 21, 2025 8:38pm

@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.52%. Comparing base (bd92fd2) to head (ae9313c).
⚠️ Report is 14 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8231      +/-   ##
==========================================
+ Coverage   76.39%   76.52%   +0.12%     
==========================================
  Files         115      117       +2     
  Lines        9643     9733      +90     
  Branches      318      330      +12     
==========================================
+ Hits         7367     7448      +81     
- Misses       2275     2283       +8     
- Partials        1        2       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Aviv Keller <[email protected]>
@avivkeller avivkeller marked this pull request as ready for review October 18, 2025 14:58
@avivkeller avivkeller requested a review from a team as a code owner October 18, 2025 14:58
@Copilot Copilot AI review requested due to automatic review settings October 18, 2025 14:58
@avivkeller avivkeller requested a review from a team as a code owner October 18, 2025 14:58
@avivkeller
Copy link
Member Author

blocked by nodejs/admin#1016

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Automate creating release blog posts and opening a PR via GitHub Actions.

  • Update the release-post script to return both the file path and metadata so the workflow can capture the version.
  • Add a GitHub Actions workflow to run the script and open/update a PR with the new blog post.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
apps/site/scripts/release-post/index.mjs Adjusts writeToFile to resolve both path and results; logs and emits version for workflow consumption.
.github/workflows/create-release-post.yml New workflow to generate a release post and open a PR, using a pinned action and step outputs.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <[email protected]>
Signed-off-by: Aviv Keller <[email protected]>
@ovflowd ovflowd marked this pull request as draft October 19, 2025 13:33
@mcollina
Copy link
Member

@RafaelGSS @nodejs/security-wg please review this.

@avivkeller avivkeller requested a review from mcollina October 21, 2025 20:36
@avivkeller avivkeller marked this pull request as ready for review October 21, 2025 20:36
@avivkeller
Copy link
Member Author

The passing of an input version is no longer optional, and a draft PR is used in place of requiring a custom token

@avivkeller
Copy link
Member Author

@mcollina could you please take another look?

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marco-ippolito
Copy link
Member

Just a random idea, maybe we could trigger automatically when a release is created on nodejs/node with https://docs.github.com/en/webhooks/webhook-events-and-payloads#repository_dispatch

@richardlau
Copy link
Member

Just a random idea, maybe we could trigger automatically when a release is created on nodejs/node with https://docs.github.com/en/webhooks/webhook-events-and-payloads#repository_dispatch

I think that's worth exploring separately from this. Just having this (and being able to manually trigger) would be a good stepping point -- for me creating the blog posts is currently one of the more time consuming parts of the release process on release day (due to needing to switch to a dev environment with pnpm and Husky pre-commit hooks).

@MattIPv4
Copy link
Member

Just a random idea, maybe we could trigger automatically when a release is created on nodejs/node with https://docs.github.com/en/webhooks/webhook-events-and-payloads#repository_dispatch

Can this be triggered from https://github.com/nodejs/node/blob/main/.github/workflows/update-release-links.yml, which is the same automation that triggers the release worker to update the files available when a new release is cut?

@avivkeller
Copy link
Member Author

That's the plan I had in mind

@avivkeller avivkeller added this pull request to the merge queue Oct 22, 2025
Merged via the queue into main with commit e75bc1b Oct 22, 2025
12 checks passed
@avivkeller avivkeller deleted the cicd-blog-post branch October 22, 2025 13:59
@avivkeller
Copy link
Member Author

See nodejs/node#60366

@avivkeller
Copy link
Member Author

@nodejs/web-infra

The action gr2m/create-or-update-pull-request-action@b65137ca591da0b9f43bad7b24df13050ea45d1b is not allowed in nodejs/nodejs.org because all actions must be from a repository owned by your enterprise, created by GitHub, or match one of the patterns: LoveToKnow/slackify-markdown-action@*, MishaKav/jest-coverage-comment@*, actions-ecosystem/action-remove-labels@*, chromaui/action@*, codecov/codecov-action@*, codecov/test-results-action@*, crowdin/github-action@*, ossf/scorecard-action@*, patrickedqvist/wait-for-vercel-preview@*, pnpm/action-setup@*, rtCamp/action-slack-notify@*, stefanzweifel/git-auto-commit-action@*, step-security/harden-runner@*, thollander/actions-comment-pull-request@*, treosh/lighthouse-ci-action@*.

@MattIPv4
Copy link
Member

We cannot fix that, new actions need to be added to the repo settings by @ovflowd or @bmuenzenmeyer (I don't see the web-admin team yet)

@bmuenzenmeyer
Copy link
Collaborator

We cannot fix that, new actions need to be added to the repo settings by @ovflowd or @bmuenzenmeyer (I don't see the web-admin team yet)

added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.