feat: redesign the previous releases page #7630
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
araujogui
changed the title
araujogui
force-pushed
the
feat/redesign-releases
branch
from
fd432c4 to
1e0ad17
Compare
|
looks good so far! Way to go! I've left one nitpick, but I know this is still a draft |
apps/site/components/Downloads/DownloadReleasesTable/DetailsButton.tsx
Outdated
Show resolved
Hide resolved
|
IMO the code name feels too small, like it's part of the modal content, I feel it like it should be prominent (if present). Maybe something like "Node.js 22 'Jod'" as a header? (I know I initially said to prefix the version w/ "v", but looking at the release lines, they aren't prefixed like that anywhere else) Also, TYSM for tackling this |
|
Wow, overall I like it. Btw, now there's a horizontal scroll on that page. |
Yeah, I will create a smaller badge size. I'm also wondering if the N-API version is relevant for the users majority |
github-actions
bot
removed
the
github_actions:pull-request
|
Lighthouse Results
|
Unit Test Coverage Report
|
Add it to Storybook :D |
|
This looks so freaking good. |
It's a site component, I guess storybook is only present on the |
|
IIRC, we agreed during the migration that the base component should be in Storybook (The Modal, which it is), and the site-specific component (the Release modal) will be validated via checking the outputted site. |
github-actions
bot
removed
the
github_actions:pull-request
apps/site/components/Downloads/ReleaseOverview/index.module.css
Outdated
Show resolved
Hide resolved
github-actions
bot
removed
the
github_actions:pull-request
There was a problem hiding this comment.
I love this little component but two points question me:
- Is it noted whether it includes corepack or not
- Shouldn't we have a "popover" that explains what the information means except for the date. For example “V8 is the JS engine behind node.js”.
There was a problem hiding this comment.
Sorry, i didn't understand the first point
There was a problem hiding this comment.
I don't think we need to indicate Corepack bundling. Users can check a given version's documentation to check whether Corepack was supported
| )} | ||
| {release.npm && ( | ||
| <Item | ||
| Icon={CodeBracketSquareIcon} |
There was a problem hiding this comment.
can we use black and white npm icon ? I think
REF:
https://docs.npmjs.com/policies/logos-and-usage#the-npm-logos
There was a problem hiding this comment.
We have to request this icon?
There was a problem hiding this comment.
Can we use the icon for npm we already have?
| <div className={styles.links}> | ||
| <Link | ||
| kind="neutral" | ||
| href={`https://nodejs.org/download/release/v${release.version}/`} |
There was a problem hiding this comment.
| href={`https://nodejs.org/download/release/v${release.version}/`} | |
| href={`/download/release/v${release.version}/`} |
Description
Redesign the Previous Releases page
Related Issues
Fixes #7445
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.