Language picker implemented - #2294
Conversation
|
@alexandrtovmach Thanks, this is great!👍 A little suggestion: can we avoid always redirecting to the home page when we change the default language ? |
|
@ZYSzys it's kind of "overcomplexity". Of course, I can write this, but this website very simple, and trying to avoid scripts as much as possible, so I decided to go with the same way. |
|
Looking good! Drive-by comment: is it possible to also display the English name of each language? For example: |
|
@zeke Thanks for proposition. Do you think that's good idea? I'm agreed with this comment, because when user looking for his language he don't need English version. In the same time if we'd add English name, it will make string longer. I think optimal way is to use |
👍 |
|
@zeke added. Thanks for help |
|
@nodejs/website-redesign：This is due to a web design function, so any other ideas about that? I agree with this :) |
|
This is looking good to me! Thanks for the PR @alexandrtovmach 💯 |
|
Thanks everyone for a review 🤗. @MaledongGit What do you think about merge? |
|
I missed the original PR.
|
ghost
mentioned this pull request
Notice: This 'rect' is invisible as a container for the language symbol to show the tooltip in both IE and Chrome, FF,ect. For reasons of accessibility, user agents should always make the content of the 'title' child element to the root svg element available to users. However, this is typically done through other means than the tooltips used for nested SVG and graphics elements, e.g., by displaying in a browser tab. See more at: https://svgwg.org/svg2-draft/struct.html#TitleElement Issues and Subjects related to this are： 1、#2294. 2、#2403. 3、#2392.
5 participants
Implemented simple language picker #806, to make better UX on the website
How it looks you can check here:
https://www.loom.com/share/9022dba48c1d42a486df212e4acabbdf