Skip to content

tools: apply feedback to and simplify contributor guidance workflow - #65785

Open
panva wants to merge 5 commits into
nodejs:mainfrom
panva:contributor-guidance-follow-up
Open

tools: apply feedback to and simplify contributor guidance workflow#65785
panva wants to merge 5 commits into
nodejs:mainfrom
panva:contributor-guidance-follow-up

Conversation

@panva

@panva panva commented Sep 4, 2026

Copy link
Copy Markdown
Member

Applying feedback from #65745 (review) and, assuming contributor-guidance.yml runs confirm it's not necessary, removing and resolving its TODO.

This is also a place to apply further feedback collected from observing the action actually run.

  • MEMBER skipped entirely
  • MEMBER w/ private organization membership resolved to MEMBER and didn't scan or post
  • CONTRIBUTOR skips posting caution
  • CONTRIBUTOR posts a caution and labels
  • FIRST_TIMER or FIRST_TIME_CONTRIBUTOR posts a welcome
  • FIRST_TIMER or FIRST_TIME_CONTRIBUTOR posts a welcome combined with a caution and labels
  • multiple concurrent FIRST_TIME_CONTRIBUTOR for the same user 33888126449, 33888131494
  • FIRST_TIME_CONTRIBUTOR welcome only evolves into a caution on the second PR, suggesting that caching may not be desired

Investigate:

  • 33886219390 Q: why did this not get skipped?
    • A: private organization membership

Suggestions:

  • Ensure label is present on all of the author's PRs? Upon classification query for other open PRs by that same author that lack the label and add it.

@panva
panva requested a review from aduh95 September 4, 2026 13:21
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Sep 4, 2026
Comment thread .github/workflows/contributor-guidance.yml
Comment thread .github/workflows/contributor-guidance.yml Outdated
@panva panva added the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label Sep 4, 2026
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva
panva force-pushed the contributor-guidance-follow-up branch 2 times, most recently from 600a8fe to d9f687b Compare September 4, 2026 14:01
@panva
panva marked this pull request as ready for review September 4, 2026 14:46
@panva panva removed the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label Sep 4, 2026
@panva
panva requested a review from aduh95 September 5, 2026 17:13

@aduh95 aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice-to-have would be to also check which base branch the PR is targeting in case it's not main, but that can be a follow-up – or not, after all it's arguably a rare enough occurrence

@panva panva added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Sep 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants