doc: (http2) update push and trailers event with rawHeaders param#63259
doc: (http2) update push and trailers event with rawHeaders param#63259samuel871211 wants to merge 1 commit into
Conversation
|
Review requested:
|
c1bb7b4 to
a76836b
Compare
pimterry
left a comment
There was a problem hiding this comment.
Nice addition, thanks for spotting & fixing this! 👍
|
Can you please change the subsystem from |
@samuel871211, I'm pretty sure @aduh95 was referring to the commit message, not PR title. |
Signed-off-by: Yu-Sheng Chen <samuel871211@gmail.com>
a76836b to
7c82b59
Compare
Ethan-Arrowood
left a comment
There was a problem hiding this comment.
make sure to run linter/formatter. I think the line 1711 needs to be wrapped.
Done with Also per
Line 1711 is 93 characters, well within the limit. Happy to be corrected if I'm missing something. |
https://github.com/nodejs/node/blob/main/lib/internal/http2/core.js#L357