Skip to content

test: migrate buffer encoding tests to node:test#63245

Closed
raashish1601 wants to merge 1 commit into
nodejs:mainfrom
raashish1601:codex/migrate-buffer-encoding-tests
Closed

test: migrate buffer encoding tests to node:test#63245
raashish1601 wants to merge 1 commit into
nodejs:mainfrom
raashish1601:codex/migrate-buffer-encoding-tests

Conversation

@raashish1601
Copy link
Copy Markdown

Refs: #47707

Migrate two small legacy script-style parallel tests to node:test:

  • test-buffer-badhex.js
  • test-bad-unicode.js

The assertions and behavior are unchanged; the test bodies are wrapped in named test() calls.

Validation:

  • node --test test/parallel/test-buffer-badhex.js test/parallel/test-bad-unicode.js
  • node -c test/parallel/test-buffer-badhex.js
  • node -c test/parallel/test-bad-unicode.js
  • node tools/eslint/node_modules/eslint/bin/eslint.js test/parallel/test-buffer-badhex.js test/parallel/test-bad-unicode.js

I could not run the project tools/test.py harness in this checkout because there is no built node.exe present.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 11, 2026
Copy link
Copy Markdown
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry but I think there is no added value here

@avivkeller
Copy link
Copy Markdown
Member

As stated above, this PR, along with the others you’ve opened, adds little meaningful value to the project. In previous interactions, you’ve also responded hostilely toward maintainers when your low-effort contributions were criticized or not merged. Given that pattern, I’m not interested in spending further time reviewing similarly low-quality submissions.

I've left an identical comment and closed your other pull requests.

@avivkeller avivkeller closed this May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants