test: migrate internal assert message test to JS#63240
Closed
raashish1601 wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Raashish Aggarwal <94279692+raashish1601@users.noreply.github.com>
nodejs-github-bot
added
needs-ci
Member
|
This PR, along with the others you’ve opened, adds little meaningful value to the project. In previous interactions, you’ve also responded hostilely toward maintainers when your low-effort contributions were criticized or not merged. Given that pattern, I’m not interested in spending further time reviewing similarly low-quality submissions. I've left an identical comment and closed your other pull requests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #47707
Migrate the
internal_assertmessage test from the legacy Python message runner to the snapshot-based JS output suite.The fixture now lives under
test/fixtures/errors, has a.snapshotfile, and is covered bytest/parallel/test-node-output-errors.mjs.Testing:
node --test --test-name-pattern internal_assert test/parallel/test-node-output-errors.mjsnode tools/eslint/node_modules/eslint/bin/eslint.js --max-warnings=0 --report-unused-disable-directives --rule "@stylistic/js/linebreak-style: 0" test/fixtures/errors/internal_assert.js test/parallel/test-node-output-errors.mjs