Open
Conversation
Collaborator
|
Review requested:
|
cjihrig
approved these changes
Feb 9, 2026
Author
|
I noticed another bug in the implementation while looking at the remaining failures here, for which I submitted tests upstream. I've added those to this PR as well. The CI failures seem to be caused by the github outage yesterday. |
Contributor
Failed to start CI⚠ Commits were pushed since the last approving review: ⚠ - test: update FileAPI tests from WPT ⚠ - fixup! test: update FileAPI tests from WPT ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/21860435679 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61750 +/- ##
========================================
Coverage 89.75% 89.75%
========================================
Files 674 675 +1
Lines 204416 204648 +232
Branches 39285 39321 +36
========================================
+ Hits 183472 183690 +218
- Misses 13227 13238 +11
- Partials 7717 7720 +3 🚀 New features to boost your workflow:
|
Collaborator
Collaborator
Author
|
It seems (thanks to Milad for pointing out #55194) that the tests involving typed arrays don't work on the big endian build bots - I hope marking them as flaky will allow the CI to pass. This seems like a better outcome than keeping the outdated tests indefinitely. |
lpinca
approved these changes
Feb 11, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notably, the
test_blob()helper functions no longer usesFileReader, so tests using them can now run successfully in node.