-
-
Notifications
You must be signed in to change notification settings - Fork 34.6k
url: update ada to v3.4.2 and support unicode 17 #61593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
url: update ada to v3.4.2 and support unicode 17 #61593
Conversation
|
Review requested:
|
bb26dde to
fe29dec
Compare
|
FWIW it doesn't require a manual PR, it's certainly fine to push a fixup commit to the bot PR, but a manual PR also works |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61593 +/- ##
==========================================
- Coverage 89.79% 89.77% -0.03%
==========================================
Files 673 673
Lines 203852 203852
Branches 39181 39182 +1
==========================================
- Hits 183044 182998 -46
- Misses 13143 13189 +46
Partials 7665 7665 🚀 New features to boost your workflow:
|
|
Landed in 356e4ae |
|
The
notable-change
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section. |
Required manual pull-request since remaining failed web-platform tests are now passing. cc @nodejs/url