Skip to content

benchmark: add benchmark utility for isNativeError function #61180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mertcanaltin wants to merge 2 commits into
base: main
Choose a base branch
from
+39 −0
Open

benchmark: add benchmark utility for isNativeError function #61180

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b40faf
benchmark: add benchmark utility for isNativeError function
mertcanaltin Dec 27, 2025
5fcf423
repair benchmark
mertcanaltin Dec 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions benchmark/util/is-native-error.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
'use strict';

const common = require('../common');

const args = {
true: new Error('test'),
falsePrimitive: 42,
falseObject: { foo: 'bar' },
};

const bench = common.createBenchmark(
main,
{
argument: ['true', 'falsePrimitive', 'falseObject'],
version: ['native', 'js'],
n: [1e6],
},
{
flags: ['--expose-internals', '--no-warnings'],
},
);

function main({ argument, version, n }) {
const util = common.binding('util');
const types = require('internal/util/types');

const func = { native: util, js: types }[version].isNativeError;

const testArgs = [args[argument], args[argument], args[argument]];
Copy link
Member

@lpinca lpinca Dec 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for this? If I'm reading correctly, the elements are all equals.

Copy link
Member Author

@mertcanaltin mertcanaltin Dec 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to provide more arguments.

Copy link
Member

@lpinca lpinca Dec 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With

const testArg = testArgs[iteration % 3];
func(testArg)

below, I'm still not sure I understand.

let sum = 0;

bench.start();
for (let iteration = 0; iteration < n; iteration++) {
const testArg = testArgs[iteration % 3];
sum += func(testArg) ? 1 : 0;
}
bench.end(n);
if (sum < 0) console.log(sum);
}
Loading