test: split test-runner-watch-mode #60391
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
The test has been flaky for years and new platforms keep popping up. As it squeezes too many independent test cases into one file, split them into individual files to avoid masking regressions and help only mark the real flaky ones as flaky. This might also help with the flakiness itself by avoiding updating a shared tmpdir being watched by differet tests and avoiding running all these time-consuming tests in one file, which can cause a timeout on slow machines.
joyeecheung
force-pushed
the
split-test-runner-watch
branch
from
83d4d97 to
711affc
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60391 +/- ##
=======================================
Coverage 88.56% 88.57%
=======================================
Files 704 704
Lines 207774 207774
Branches 40025 40029 +4
=======================================
+ Hits 184022 184039 +17
+ Misses 15807 15788 -19
- Partials 7945 7947 +2 🚀 New features to boost your workflow:
|
gurgunday
approved these changes
Oct 25, 2025
github-actions
bot
removed
the
request-ci
MoLow
approved these changes
Oct 26, 2025
jakecastelli
approved these changes
Oct 26, 2025
atlowChemi
approved these changes
Oct 26, 2025
This was referenced Oct 27, 2025
MoLow
added
the
author ready
aduh95
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 28, 2025
PR-URL: #60391 Refs: #49605 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
|
Landed in e0ca993...7c0995c |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 28, 2025
The test has been flaky for years and new platforms keep popping up. As it squeezes too many independent test cases into one file, split them into individual files to avoid masking regressions and help only mark the real flaky ones as flaky. This might also help with the flakiness itself by avoiding updating a shared tmpdir being watched by differet tests and avoiding running all these time-consuming tests in one file, which can cause a timeout on slow machines. PR-URL: #60391 Refs: #49605 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test has been flaky for years and new platforms keep popping
up. As it squeezes too many independent test cases into one file,
split them into individual files to avoid masking regressions
and help only mark the real flaky ones as flaky. This might also
help with the flakiness itself by avoiding updating a shared tmpdir
being watched by differet tests and avoiding running all these
time-consuming tests in one file, which can cause a timeout
on slow machines.
Refs: #49605