perf_hooks: move non-standard performance properties to perf_hooks #60370
+186
−131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`performance.eventLoopUtilization` and `performance.timerify` are not part of the Web API. Expose these two functions directly on the `perf_hooks` module.
nodejs-github-bot
added
needs-ci
legendecas
commented
Oct 22, 2025
| --> | ||
|
|
||
| An object that can be used to query performance information from a worker | ||
| instance. Similar to [`perf_hooks.performance`][]. |
There was a problem hiding this comment.
worker.performance is not similar to perf_hooks.performance at all. It has only one method eventLoopUtilization.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60370 +/- ##
==========================================
+ Coverage 88.56% 88.58% +0.01%
==========================================
Files 704 704
Lines 208398 207778 -620
Branches 40057 40026 -31
==========================================
- Hits 184573 184063 -510
+ Misses 15846 15760 -86
+ Partials 7979 7955 -24
🚀 New features to boost your workflow:
|
joyeecheung
approved these changes
Oct 22, 2025
marco-ippolito
approved these changes
Oct 23, 2025
cjihrig
approved these changes
Oct 23, 2025
mertcanaltin
approved these changes
Oct 26, 2025
aduh95
added
the
author ready
aduh95
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/60370 ✔ Done loading data for nodejs/node/pull/60370 ----------------------------------- PR info ------------------------------------ Title perf_hooks: move non-standard performance properties to perf_hooks (#60370) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch legendecas:perf-elu -> nodejs:main Labels author ready, perf_hooks, needs-ci, commit-queue-squash, web-standards Commits 2 - perf_hooks: move non-standard performance properties to perf_hooks - fixup! perf_hooks: move non-standard performance properties to perf_h… Committers 1 - Chengzhong Wu <[email protected]> PR-URL: https://github.com/nodejs/node/pull/60370 Fixes: https://github.com/nodejs/node/issues/60368 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/60370 Fixes: https://github.com/nodejs/node/issues/60368 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - perf_hooks: move non-standard performance properties to perf_hooks ⚠ - fixup! perf_hooks: move non-standard performance properties to perf_h… ℹ This PR was created on Wed, 22 Oct 2025 19:52:54 GMT ✔ Approvals: 3 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/60370#pullrequestreview-3367779455 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/60370#pullrequestreview-3368304491 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/60370#pullrequestreview-3370054097 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-10-27T22:14:00Z: https://ci.nodejs.org/job/node-test-pull-request/69910/ - Querying data for job/node-test-pull-request/69910/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/18858748314 |
|
Landed in 51a57f2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
performance.eventLoopUtilizationandperformance.timerifyare notpart of the Web API. Expose these two functions directly on the
perf_hooksmodule instead.Though, this does not deprecate
performance.eventLoopUtilizationandperformance.timerifyyet.Fixes: #60368