Skip to content

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Sep 2, 2025

Fixes #59719

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Sep 2, 2025
@MoLow MoLow force-pushed the fix-todo-inheritance branch from 5f51a78 to 4d1f8c2 Compare September 2, 2025 09:27
@MoLow MoLow changed the title test-runner: fix todo inheritance test_-_runner: fix todo inheritance Sep 2, 2025
@MoLow MoLow changed the title test_-_runner: fix todo inheritance test_runner: fix todo inheritance Sep 2, 2025
@MoLow MoLow force-pushed the fix-todo-inheritance branch from 4d1f8c2 to d9720e9 Compare September 2, 2025 09:39
Copy link

codecov bot commented Sep 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.92%. Comparing base (961554c) to head (d9720e9).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #59721      +/-   ##
==========================================
- Coverage   89.93%   89.92%   -0.02%     
==========================================
  Files         667      667              
  Lines      196775   196775              
  Branches    38409    38417       +8     
==========================================
- Hits       176977   176941      -36     
+ Misses      12247    12246       -1     
- Partials     7551     7588      +37     
Files with missing lines Coverage Δ
lib/internal/test_runner/test.js 97.36% <100.00%> (ø)

... and 42 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 2, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 2, 2025
@nodejs-github-bot
Copy link
Collaborator

@MoLow MoLow added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 2, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 3, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 4, 2025
@nodejs-github-bot nodejs-github-bot merged commit 2258f22 into nodejs:main Sep 4, 2025
64 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 2258f22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test runner: subtests failures are not ignored when parent has todo
7 participants