src: fix build on NetBSD #59718
Merged
src: fix build on NetBSD #59718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include missing cmath.h header. Fixes: nodejs#59714
nodejs-github-bot
added
c++
targos
approved these changes
Sep 2, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59718 +/- ##
==========================================
- Coverage 89.93% 89.92% -0.02%
==========================================
Files 667 667
Lines 196775 196775
Branches 38409 38413 +4
==========================================
- Hits 176977 176951 -26
+ Misses 12247 12241 -6
- Partials 7551 7583 +32
🚀 New features to boost your workflow:
|
github-actions
bot
removed
the
request-ci
UlisesGascon
approved these changes
Sep 2, 2025
richardlau
approved these changes
Sep 2, 2025
addaleax
approved these changes
Sep 2, 2025
addaleax
added
the
author ready
lpinca
approved these changes
Sep 2, 2025
richardlau
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 5600c0e |
targos
pushed a commit
that referenced
this pull request
Sep 4, 2025
Include missing cmath.h header. Fixes: #59714 PR-URL: #59718 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include missing cmath.h header.
Fixes: #59714