doc: clarify ERR_FS_FILE_TOO_LARGE explanation to reflect fs.readFile() I/O limit #59050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
jasnell
reviewed
Jul 13, 2025
jasnell
approved these changes
Jul 13, 2025
lpinca
approved these changes
Jul 13, 2025
LiviaMedeiros
approved these changes
Jul 13, 2025
LiviaMedeiros
added
author ready
|
LGTM with adjusting the commit message to adhere guidelines (the message length has to be 72 or less). |
Co-authored-by: James M Snell <[email protected]>
|
The commit message has been updated per guidelines and all reviews are approved. |
LiviaMedeiros
added
the
author ready
LiviaMedeiros
approved these changes
Jul 14, 2025
There was a problem hiding this comment.
Thank you.
A pull request needs to stay open for at least 48 hours from when it is submitted (which makes about 32 more hours from now), and afterwards any collaborator can merge this.
|
All reviews are done and 48 hours have passed. Could someone please merge this? 🙏 |
LiviaMedeiros
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
This comment was marked as outdated.
This comment was marked as outdated.
LiviaMedeiros
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 9f486c3 |
targos
pushed a commit
that referenced
this pull request
Jul 17, 2025
PR-URL: #59050 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: clarify ERR_FS_FILE_TOO_LARGE message to reflect fs.readFile() I/O limit
The error previously suggested the issue might be due to Buffer limitations,
but in fact it's an internal constraint of fs.readFile(). Updated the
documentation to avoid confusion and guide users toward fs.createReadStream()
for large files.
ref #55864