Skip to content

[v24.x] deps: V8: backport 1c3e018e7d48 #58818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Renegade334 wants to merge 1 commit into from
Closed

[v24.x] deps: V8: backport 1c3e018e7d48 #58818

Renegade334 wants to merge 1 commit into from

Conversation

@Renegade334
Copy link
Member

@Renegade334 Renegade334 commented Jun 24, 2025

This backport from 13.7 facilitates defining ERM disposal methods within the C++ layer.

Original commit message:

Expose dispose and asyncDispose symbols to C++

Since `Symbol.dispose` has been exposed to JS we need to be able to
access the native v8::Symbol too.

Change-Id: I9111d2806630efdd8bb5f931effa9adad3c85ae5
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6410112
Commit-Queue: Erik Corry <[email protected]>
Reviewed-by: Erik Corry <[email protected]>
Reviewed-by: Leszek Swirski <[email protected]>
Cr-Commit-Position: refs/heads/main@{#99590}

refs: v8/v8@1c3e018

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 24, 2025

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch. v8 engine Issues and PRs related to the V8 dependency. labels Jun 24, 2025
@Renegade334 Renegade334 marked this pull request as ready for review June 24, 2025 19:14
@RafaelGSS
Copy link
Member

RafaelGSS commented Jun 25, 2025

Is there any reason not to have it on main as well?

@Renegade334
Copy link
Member Author

Renegade334 commented Jun 25, 2025

It already is, via #58064.

@Renegade334 Renegade334 mentioned this pull request Jun 29, 2025
Closed
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 1, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 1, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 1, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/67776/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 1, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6638/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 1, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6638/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 1, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6638/

@Renegade334 Renegade334 force-pushed the v8-backport-api-dispose-symbols branch from 546c1e4 to 131e45c Compare July 23, 2025 10:11
@Renegade334
Copy link
Member Author

Renegade334 commented Jul 23, 2025

Rebased for embedder string.

@Renegade334 Renegade334 requested review from RafaelGSS and targos July 23, 2025 10:12
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 23, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 23, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 23, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68148/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 23, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6671/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 23, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6671/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 23, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6671/

@Renegade334 Renegade334 force-pushed the v8-backport-api-dispose-symbols branch 2 times, most recently from bca9f5d to 9553588 Compare August 5, 2025 23:19
@Renegade334
deps: V8: backport 1c3e018e7d48
15859d3 
Original commit message:

    Expose dispose and asyncDispose symbols to C++

    Since `Symbol.dispose` has been exposed to JS we need to be able to
    access the native v8::Symbol too.

    Change-Id: I9111d2806630efdd8bb5f931effa9adad3c85ae5
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6410112
    Commit-Queue: Erik Corry <[email protected]>
    Reviewed-by: Erik Corry <[email protected]>
    Reviewed-by: Leszek Swirski <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#99590}
@Renegade334 Renegade334 force-pushed the v8-backport-api-dispose-symbols branch from 9553588 to 15859d3 Compare August 5, 2025 23:19
@Renegade334
Copy link
Member Author

Renegade334 commented Aug 6, 2025

The last CI run was a flaky mess – could this get a fresh one?

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 6, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 6, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 6, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68436/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 6, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6689/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 6, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6689/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 6, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6689/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 6, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68441/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 7, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68469/

@targos
Copy link
Member

targos commented Aug 8, 2025

Landed in 0566799

@targos targos closed this Aug 8, 2025
@Renegade334 Renegade334 deleted the v8-backport-api-dispose-symbols branch August 8, 2025 14:12
@github-actions github-actions bot mentioned this pull request Aug 11, 2025
Merged
@aduh95 aduh95 added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targos targos targos approved these changes

@RafaelGSS RafaelGSS Awaiting requested review from RafaelGSS

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Renegade334 @nodejs-github-bot @RafaelGSS @targos @richardlau @aduh95