test: check stability block position in API markdown#58590
Open
Renegade334 wants to merge 1 commit intonodejs:mainfrom
Open
test: check stability block position in API markdown#58590Renegade334 wants to merge 1 commit intonodejs:mainfrom
Renegade334 wants to merge 1 commit intonodejs:mainfrom
Conversation
7bdc418 to
c41bd3e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #58590 +/- ##
==========================================
- Coverage 90.21% 90.20% -0.01%
==========================================
Files 635 635
Lines 187494 187495 +1
Branches 36838 36818 -20
==========================================
- Hits 169144 169129 -15
+ Misses 11145 11117 -28
- Partials 7205 7249 +44 🚀 New features to boost your workflow:
|
c41bd3e to
91a8078
Compare
anonrig
approved these changes
Jun 8, 2025
lpinca
approved these changes
Jun 14, 2025
Ethan-Arrowood
approved these changes
Jun 14, 2025
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
91a8078 to
f523724
Compare
Member
Author
|
Rebased as an additional failure case was introduced since the original commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The doc generator will only add a stability marker to the index if the blockquote element appears close to the relevant heading. There is an ordering convention (<heading> [<yaml>] <stability>) which is not currently enforced.
Adding a test for this identifies one element which is currently non-compliant,
buf.slice()in buffer.md, which does not appear as deprecated in the index due to the malpositioned deprecation block.