tools: lint typescript files

[Jorgee97]

closes #55702 by adding typescript-eslint to the linting rules.

Thanks to @avivkeller for this closed PR #55709.

[nodejs-github-bot]

Review requested:

• @nodejs/performance
• @nodejs/typescript

[avivkeller]

Hiya! I contributed part of this change, so I'd love if you could add me as a Co-Author.

Thanks!

[Jorgee97]

Hiya! I contributed part of this change, so I'd love if you could add me as a Co-Author.

Thanks!

Sorry for not doing that before, TIL about co-authoring commits.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.07%. Comparing base (8173d9d) to head (d22eaf2).

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #58256      +/-   ##
==========================================
- Coverage   90.09%   90.07%   -0.02%     
==========================================
  Files         640      640              
  Lines      188462   188462              
  Branches    36962    36961       -1     
==========================================
- Hits       169786   169766      -20     
- Misses      11404    11413       +9     
- Partials     7272     7283      +11     

see 27 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66742/

[JakobJingleheimer]

Hiya! I contributed part of this change, so I'd love if you could add me as a Co-Author.
Thanks!

Sorry for not doing that before, TIL about co-authoring commits.

I think in order for co-authorship to work in this repo, you must add the co-author to the first commit (it's currently applied to an intermediary commit, which will get flattened and thus the co-authorship lost).

[DanielRosenwasser]

Feels like the idea of linting test files like this is not a good idea - don't you want to have a variety of styles tested?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/67659/

[aduh95]

My advice would be to start much smaller (e.g. only linting TS files in one subfolder), that way it's easier to get reviewed and less likely to get conflicts. Once the first PR has landed, you can send PRs for other subfolders.