-
-
Notifications
You must be signed in to change notification settings - Fork 33.3k
util: update util.isArray() to eol #58027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
It seems like there is still some hesitation about doing this - #58013 (comment). |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #58027 +/- ##
==========================================
- Coverage 88.45% 88.45% -0.01%
==========================================
Files 703 703
Lines 207544 207541 -3
Branches 40013 40010 -3
==========================================
- Hits 183587 183580 -7
+ Misses 15965 15950 -15
- Partials 7992 8011 +19
🚀 New features to boost your workflow:
|
I think build is failing because a link to the |
Failed to start CI⚠ Commits were pushed since the last approving review: ⚠ - util: update util.isArray() to eol ⚠ - Update version change with pr number ⚠ - fix endoflife typo ⚠ - Fix typo from version ⚠ - doc: update deprecation notice for util.isArray() removal ⚠ - doc: remove unused reference to Array.isArray() in util documentation ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/14686825918 |
d29f97e
to
d819523
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still encounter this API in the wild a fair amount. I'm not all that convinced we should move this one of EOL just yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 Moving this EOL to Node.js 26.
@RafaelGSS Cool, I'll fix the conflicts today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For 26, ok. I still think this one is going to end up a bit more disruptive but that's what semver-major is for.
d819523
to
98d5b07
Compare
Let's land it only when v25 goes out. Due to the upcoming V8 update, I might need to sync |
Refs #58013
Update
util.isArray
to eol