-
Notifications
You must be signed in to change notification settings - Fork 31.3k
build: fix missing files warning #57870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lpinca
wants to merge
1
commit into
nodejs:main
Choose a base branch
from
lpinca:fix/warning
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
RaisinTen
approved these changes
Apr 14, 2025
marco-ippolito
approved these changes
Apr 14, 2025
jasnell
approved these changes
Apr 14, 2025
This commit fixes the following warning: Warning: Missing input files: C:\Users\lpinca\node\tools\v8_gypfiles\..\..\deps\v8\third_party\abseil-cpp\absl\strings\internal\has_absl_stringify.h C:\Users\lpinca\node\deps\ncrypto\dh-primes.h nodejs@bd3c25cf31282f101196 removed `'<(ABSEIL_ROOT)/absl/strings/has_absl_stringify.h'` instead of `'<(ABSEIL_ROOT)/absl/strings/internal/has_absl_stringify.h'` Refs: nodejs@5ab3140dfbf0dfa33a66 Refs: nodejs@b9b4cb7731168671d8f4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file.
needs-ci
PRs that need a full CI run.
tools
Issues and PRs related to the tools directory.
v8 engine
Issues and PRs related to the V8 dependency.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the following warning:
bd3c25cf31282f101196 removed
'<(ABSEIL_ROOT)/absl/strings/has_absl_stringify.h'
instead of'<(ABSEIL_ROOT)/absl/strings/internal/has_absl_stringify.h'
Refs: 5ab3140dfbf0dfa33a66
Refs: b9b4cb7731168671d8f4