src: fix typo in comments #57868
Open
src: fix typo in comments #57868
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57868 +/- ##
==========================================
- Coverage 90.24% 90.24% -0.01%
==========================================
Files 630 630
Lines 185502 185670 +168
Branches 36366 36401 +35
==========================================
+ Hits 167402 167552 +150
+ Misses 11000 10992 -8
- Partials 7100 7126 +26
🚀 New features to boost your workflow:
|
RaisinTen
approved these changes
Apr 14, 2025
lpinca
approved these changes
Apr 14, 2025
|
I have a silly question. Do I need to run CI here? |
cjihrig
approved these changes
Apr 14, 2025
Yes, since this is a change to the source code. |
great. ty |
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
approved these changes
Apr 14, 2025
jasnell
added
author ready
bjohansebas
approved these changes
Apr 14, 2025
Ayase-252
approved these changes
Apr 15, 2025
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/57868 ✔ Done loading data for nodejs/node/pull/57868 ----------------------------------- PR info ------------------------------------ Title src: fix typo in comments (#57868) Author Edy Silva <[email protected]> (@geeksilva97) Branch geeksilva97:fix-typo-in-comments -> nodejs:main Labels c++, author ready, needs-ci, sqlite Commits 1 - src: fix typo in comments Committers 1 - Edy Silva <[email protected]> PR-URL: https://github.com/nodejs/node/pull/57868 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Qingyu Deng <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/57868 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Qingyu Deng <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 13 Apr 2025 22:50:39 GMT ✔ Approvals: 5 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/57868#pullrequestreview-2763129313 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/57868#pullrequestreview-2763291828 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/57868#pullrequestreview-2764259918 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/57868#pullrequestreview-2764666235 ✔ - Qingyu Deng (@Ayase-252): https://github.com/nodejs/node/pull/57868#pullrequestreview-2766864878 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2025-04-14T18:28:00Z: https://ci.nodejs.org/job/node-test-pull-request/66267/ - Querying data for job/node-test-pull-request/66267/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/14480877191 |
geeksilva97
added
request-ci
github-actions
bot
removed
the
request-ci
himself65
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a typo in
node_sqlite.ccfile