-
Notifications
You must be signed in to change notification settings - Fork 31.3k
sqlite: add location method #57860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
sqlite: add location method #57860
Conversation
Review requested:
|
This would simplify the sharing of connections between modules. When needed, they could retrieve the database location using only the object. I'm aware some of you might find this useless. Whatever you guys decide, I'm okay with it. I just needed something like this and decided to implement. |
6de740a
to
b42a338
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #57860 +/- ##
========================================
Coverage 90.24% 90.24%
========================================
Files 630 630
Lines 185502 185693 +191
Branches 36366 36416 +50
========================================
+ Hits 167402 167587 +185
Misses 11000 11000
- Partials 7100 7106 +6
🚀 New features to boost your workflow:
|
f46394b
to
e7817bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM besides the one unrelated change.
e7817bf
to
48a8353
Compare
48a8353
to
e0418ab
Compare
Fixes #57859