Skip to content

sqlite: add location method #57860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

geeksilva97
Copy link
Contributor

Fixes #57859

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/sqlite

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Apr 13, 2025
@geeksilva97
Copy link
Contributor Author

This would simplify the sharing of connections between modules. When needed, they could retrieve the database location using only the object.

I'm aware some of you might find this useless. Whatever you guys decide, I'm okay with it. I just needed something like this and decided to implement.

@geeksilva97 geeksilva97 force-pushed the sqlite-add-location-function branch from 6de740a to b42a338 Compare April 13, 2025 03:49
Copy link

codecov bot commented Apr 13, 2025

Codecov Report

Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.24%. Comparing base (09ecd2e) to head (a489f6f).
Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
src/node_sqlite.cc 82.60% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main   #57860    +/-   ##
========================================
  Coverage   90.24%   90.24%            
========================================
  Files         630      630            
  Lines      185502   185693   +191     
  Branches    36366    36416    +50     
========================================
+ Hits       167402   167587   +185     
  Misses      11000    11000            
- Partials     7100     7106     +6     
Files with missing lines Coverage Δ
src/node_sqlite.h 68.00% <ø> (ø)
src/node_sqlite.cc 80.51% <82.60%> (+0.02%) ⬆️

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@geeksilva97 geeksilva97 force-pushed the sqlite-add-location-function branch 2 times, most recently from f46394b to e7817bf Compare April 13, 2025 20:59
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides the one unrelated change.

@geeksilva97 geeksilva97 force-pushed the sqlite-add-location-function branch from e7817bf to 48a8353 Compare April 13, 2025 22:46
@geeksilva97 geeksilva97 force-pushed the sqlite-add-location-function branch from 48a8353 to e0418ab Compare April 13, 2025 22:49
@geeksilva97 geeksilva97 added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 14, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 14, 2025
@nodejs-github-bot
Copy link
Collaborator

@geeksilva97 geeksilva97 added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 16, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 16, 2025
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a method for retrieving the database location
6 participants