Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add "Skip to content" button #56750

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jan 24, 2025

Useful especially for folks using a screen reader.

WCAG Reference: WCAG 2.0 Technique G1

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/nodejs-website

@aduh95 aduh95 added lts-watch-v18.x PRs that may need to be released in v18.x. lts-watch-v20.x PRs that may need to be released in v20.x lts-watch-v22.x PRs that may need to be released in v22.x labels Jan 24, 2025
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 24, 2025
@jasnell
Copy link
Member

jasnell commented Jan 24, 2025

Nit: for these kinds of PRs, it's helpful to include a screenshot as to what the rendered change would look like.

@aduh95
Copy link
Contributor Author

aduh95 commented Jan 24, 2025

It looks like this when the button is in focus:

dark mode

light mode

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 24, 2025
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 25, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 26, 2025
@nodejs-github-bot nodejs-github-bot merged commit f1196ee into nodejs:main Jan 26, 2025
38 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in f1196ee

@aduh95 aduh95 deleted the skip-to-content branch January 26, 2025 23:55
aduh95 added a commit to nodejs/api-docs-tooling that referenced this pull request Jan 27, 2025
PR-URL: nodejs/node#56750
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
aduh95 added a commit to nodejs/api-docs-tooling that referenced this pull request Jan 27, 2025
PR-URL: nodejs/node#56750
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
aduh95 added a commit that referenced this pull request Jan 27, 2025
PR-URL: #56750
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
aduh95 added a commit that referenced this pull request Jan 30, 2025
PR-URL: #56750
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
hvanness pushed a commit to hvanness/node that referenced this pull request Jan 30, 2025
PR-URL: nodejs#56750
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
aduh95 added a commit that referenced this pull request Jan 31, 2025
PR-URL: #56750
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
@aduh95 aduh95 removed the lts-watch-v22.x PRs that may need to be released in v22.x label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. lts-watch-v18.x PRs that may need to be released in v18.x. lts-watch-v20.x PRs that may need to be released in v20.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants