fix(ncu-config): support encrypted config in ncu-config#964
Merged
joyeecheung merged 1 commit intonodejs:mainfrom Sep 17, 2025
Merged
fix(ncu-config): support encrypted config in ncu-config#964joyeecheung merged 1 commit intonodejs:mainfrom
joyeecheung merged 1 commit intonodejs:mainfrom
Conversation
This otherwise always re-write the config into ~/.ncurc instead of ~/.ncurc.gpg
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #964 +/- ##
==========================================
- Coverage 80.06% 79.75% -0.31%
==========================================
Files 39 39
Lines 4645 4663 +18
==========================================
Hits 3719 3719
- Misses 926 944 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aduh95
reviewed
Aug 9, 2025
| const configPath = getConfigPath(configType, dir); | ||
| const encryptedConfigPath = configPath + '.gpg'; | ||
| if (existsSync(encryptedConfigPath)) { | ||
| const tmpDir = mkdtempSync(path.join(os.tmpdir(), 'ncurc-')); |
Contributor
There was a problem hiding this comment.
Could we use stdin instead of a temp dir?
Member
Author
There was a problem hiding this comment.
From local testing, this does not quite work if pinentry program is not using stdin for input (e.g. if it's a GUI dialog).
richardlau
approved these changes
Sep 17, 2025
RafaelGSS
approved these changes
Sep 17, 2025
BridgeAR
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This otherwise always re-write the config into ~/.ncurc instead of ~/.ncurc.gpg
Refs: #615