Do not compare dates to detect new commits#911
Merged
aduh95 merged 3 commits intonodejs:mainfrom Mar 28, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #911 +/- ##
==========================================
- Coverage 79.86% 79.70% -0.17%
==========================================
Files 39 39
Lines 4684 4641 -43
==========================================
- Hits 3741 3699 -42
+ Misses 943 942 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/cc @nodejs/node-core-utils |
targos
approved these changes
Mar 28, 2025
VoltrexKeyva
approved these changes
Mar 28, 2025
This reverts commit 6cc2b1a.
Changes have been made on Jenkins side, tip of the PR head must be sent to Jenkins in order to start a PR. This commit adapts ncu-ci CLI to pass that information – or get the SHA from the latest review if not passed.
...to display commits pushed since last approving review. It would only matter if time on the comitter machine is very different from GitHub's own time. That allows us to skip quering for `timelineItems`.
aduh95
force-pushed
the
do-not-rely-timelineItems
branch
from
9c7f488 to
cdf482f
Compare
This was referenced Mar 28, 2025
richardlau
added a commit
to richardlau/node-core-utils
that referenced
this pull request
May 9, 2025
Similar to `node-test-pull-request`, `node-test-commit-v8-linux` also now requires `COMMIT_SHA_CHECK` to be passed to it. Refs: nodejs#911
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NCU was relying on
timelineItemsto get date for the last push event, but turns out that gives us the commit date (not very relevant for what we're testing as the commit and push can be done at different moment), not the date when the push was received by GH servers. What we can do instead is to use the SHA of the commit, and compare it with the last approving review.I also take the opportunity to update
ncu-cito pass the now required commit SHA (I reused the--certify-safeflag for that), I didn't mark it as semver-major given that the breaking change was made upstream, so the PR is fixing, rather than breaking, but happy to reconsider.This will have the effect of making
request-ciwork only on approved PRs, but currently it is not working at all, so I'd take as an improvement.Commits should land separately, and it probably makes sense to review them separately as well.