feat(v8): add command to sync V8 deps#1016
Merged
joyeecheung merged 1 commit intonodejs:mainfrom Dec 20, 2025
Merged
Conversation
Add `git node v8 deps` to (re)sync V8 dependencies from V8's `DEPS` file.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1016 +/- ##
=======================================
Coverage 80.58% 80.58%
=======================================
Files 39 39
Lines 4754 4754
=======================================
Hits 3831 3831
Misses 923 923 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
targos
approved these changes
Dec 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
git node v8 depsto (re)sync V8 dependencies from V8'sDEPSfile.I started on this while exploring potentially adding Chromium's Rust crates (
third_party/rust) to the Node.js source tree (although it looks like we might do our own vendoring to potentially allow other uses of Rust). It will also be useful for exploring addingthird_party/libc++/srcfor V8's custom_libcxx to avoid requiring libatomic.On its own it shouldn't do anything (other than revert any patches we have floated on top of the third_party deps). Its main use would be to test updates to
lib/update-v8/constants.jsor even V8's DEPS (if we ever want to roll forward a dependency (I expect that to be rare/unlikely)).