-
Notifications
You must be signed in to change notification settings - Fork 17
feat(badge): use info
badge
#411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the badge styling for the MetaBar component by replacing the 'default' badge type with 'info' to better align with the blue color scheme used in legacy code. The change was introduced alongside the addition of an EOL page that provided additional badge types.
- Replaces 'default' badge type with 'info' in the STABILITY_KINDS array
- Updates the @node-core/ui-components dependency to include the new 'info' badge type
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
src/generators/web/ui/components/MetaBar/index.jsx | Changes badge type from 'default' to 'info' in STABILITY_KINDS array |
package.json | Updates @node-core/ui-components dependency version to support new badge types |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conflicts
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #411 +/- ##
=======================================
Coverage 74.22% 74.22%
=======================================
Files 118 118
Lines 10994 10994
Branches 696 696
=======================================
Hits 8160 8160
Misses 2831 2831
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I'm aware the web generator is failing. It's unrelated to this PR, and I'll investigate it soon. Merging |
The addition of the EOL page also introduced more badge types. The new
info
badge better aligns with the color scheme of legacy code (Blue)