-
-
Notifications
You must be signed in to change notification settings - Fork 43
feat: updated, refactored and cleaned up #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think it would be good to get the updated version working/tested in real life before landing changes to the repo. I won't have time to debug if changes break the live tooling which regularly updates from this repo to pull in changes. |
+1. I haven't tested this for real yet, so we shouldn't land before I'm able to confirm it works fine. Would unit testing also make sense here? |
Adding HackMD docs as we're closing a partnership with'em. |
cc @avivkeller ☝️ |
FYI this PR staled a bit as I'm going to work next weekend on (Aiming the Sunday or Saturday) (16th/17th of August) |
cc @mhdawson this PR is ready to be reviewed and merged once we set the tokens 🙇 |
@bensternthal / @ryanaslett I'm ready to set the tokens once openjs-foundation/infrastructure#78 gets done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The remaining comments of mine are nitpicks.
LGTM, thank you, Claudio!
Co-authored-by: Aviv Keller <[email protected]>
Co-authored-by: Aviv Keller <[email protected]>
This PR removes the usage of very old dependencies for the ones maintained officially by Google with updated APIs.
This PR refactors and modularizes the source code and ensures it is functional via environmnent-based configuration, instead of fie-system ones.
It also amplifies the code, documentation and ensures it is easy to contribute towards.