Skip to content

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Jul 4, 2025

This PR removes the usage of very old dependencies for the ones maintained officially by Google with updated APIs.

This PR refactors and modularizes the source code and ensures it is functional via environmnent-based configuration, instead of fie-system ones.

It also amplifies the code, documentation and ensures it is easy to contribute towards.

@mhdawson
Copy link
Member

mhdawson commented Jul 4, 2025

I think it would be good to get the updated version working/tested in real life before landing changes to the repo. I won't have time to debug if changes break the live tooling which regularly updates from this repo to pull in changes.

@ovflowd
Copy link
Member Author

ovflowd commented Jul 4, 2025

I think it would be good to get the updated version working/tested in real life before landing changes to the repo. I won't have time to debug if changes break the live tooling which regularly updates from this repo to pull in changes.

+1. I haven't tested this for real yet, so we shouldn't land before I'm able to confirm it works fine. Would unit testing also make sense here?

@ovflowd
Copy link
Member Author

ovflowd commented Jul 21, 2025

@ovflowd
Copy link
Member Author

ovflowd commented Jul 21, 2025

cc @avivkeller ☝️

@ovflowd
Copy link
Member Author

ovflowd commented Aug 9, 2025

FYI this PR staled a bit as I'm going to work next weekend on (Aiming the Sunday or Saturday) (16th/17th of August)

@ovflowd
Copy link
Member Author

ovflowd commented Aug 14, 2025

cc @mhdawson this PR is ready to be reviewed and merged once we set the tokens 🙇

@ovflowd
Copy link
Member Author

ovflowd commented Aug 19, 2025

@bensternthal / @ryanaslett I'm ready to set the tokens once openjs-foundation/infrastructure#78 gets done.

Copy link
Member

@avivkeller avivkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The remaining comments of mine are nitpicks.

LGTM, thank you, Claudio!

ovflowd and others added 3 commits September 17, 2025 22:09
@ovflowd ovflowd merged commit 2ff4b68 into nodejs:main Sep 17, 2025
@ovflowd ovflowd deleted the feat/updated-and-refactored branch September 17, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants