feat: Adds guard to avoid stepping on Yarn's feet #714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduh95
reviewed
May 27, 2025
aduh95
reviewed
May 27, 2025
aduh95
reviewed
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on an experimental alternative to Corepack that also replaces the binary (while I'm pretty sure this experimental alternative will be released in some way, I don't plan to remove Yarn support from Corepack; this is more intended to avoid having all our eggs in the same basket).
To make sure it interacts correctly with Corepack, this PR adds a check to avoid accidentally erasing the experimental Yarn jumper when running
corepack enable/corepack disable(with the rational that an "official" jumper would always necessarily know how to fetch Yarn versions, whereas Corepack could conceivably lag in implementing support for future url patterns; so it should have priority).