Merged
Conversation
Signed-off-by: Michael Dawson <midawson@redhat.com>
styfle
reviewed
Jan 11, 2024
| * Ruy, definitely going to be a large breaking change | ||
| * Geoffrey, the person who wants to champion removal of npm should write up proposal and | ||
| then we vote on that. | ||
| * Ruy, has been mentioned that distributing npm as are of corepack might not be legally ok. |
Member
There was a problem hiding this comment.
Does corepack actually redistribute npm, or does it just fetch it from the registry?
See related nodejs/corepack#104 (comment)
Member
Author
There was a problem hiding this comment.
@styfle I think thats a reasonable question, but the notes are meant to record what Ruy say so I don't think we necessarily need to update them to answer the question.
Member
There was a problem hiding this comment.
Makes sense 👍
I came here from nodejs/corepack#104 (comment)
I just didn't know where to leave comments at the time.
I think probably here: nodejs/node#50963
Member
Author
|
@nodejs/tsc could I get an approval or two so that I can land this? |
ruyadorno
approved these changes
Jan 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.