-
-
Notifications
You must be signed in to change notification settings - Fork 684
Improve examples and tests #523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Here we have ba8c8b4 one more test we probably should add too. I'm not sure what |
This pull request introduces 1 alert when merging 9238091 into ca2c2b1 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging e4e3485 into ca2c2b1 - view on LGTM.com new alerts:
|
ok you can merge when you want |
This pull request introduces 1 alert when merging 4568007 into ca2c2b1 - view on LGTM.com new alerts:
|
Can we merge this ? |
Probably.
|
Are we still using test/legacy. I don't know how to cherry pick from another that so I created a new commit |
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: yiminghe <[email protected]>
I don't know. Just for consistency for now :D Tests are failing https://travis-ci.org/node-formidable/node-formidable/jobs/620813815#L214 ... For some reason it doesn't make array of fields. The DANG! Tests are awfully awful. :D |
fixes #518