This repository was archived by the owner on Dec 24, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds barebones tests here against our
sharkbox1
Linux/Phoenix runner. The two tests added arexrt_style_chaining
test, which sketches/emulates HSA but doesn't actually connect to HSA;add_one_dispatch
test, which does connect to HSA.Since the base branch is
amd-staging
, and not all of @atgutier's commits have landed there yet,add_one_dispatch
currently fails (well XFAILs). I haven't tried it yet, but I believe on #14 it will pass - I haven't tried it because while you can run CI for PRs to the default branch (amd-staging
) that introduce a new action/workflow, you cannot run CI for PRs to other branches until the action/workflow has landed in the default branch.I'm skipping the line for this one ("force merging") for the sake of having some tests (and because it's a long weekend) but from now on all PRs will require review (including for myself and other admins).
FYI this same workflow can be used to cut a "release" that gets deposited at https://github.com/nod-ai/ROCR-Runtime/releases/tag/latest
cc @MaheshRavishankar @jtuyls @kumardeepakamd