Skip to content
This repository was archived by the owner on Dec 24, 2024. It is now read-only.

AIE CI tests #10

Merged
merged 2 commits into from
Aug 31, 2024
Merged

AIE CI tests #10

merged 2 commits into from
Aug 31, 2024

Conversation

makslevental
Copy link
Collaborator

@makslevental makslevental commented Aug 30, 2024

This PR adds barebones tests here against our sharkbox1 Linux/Phoenix runner. The two tests added are

  1. @eddierichter-amd's xrt_style_chaining test, which sketches/emulates HSA but doesn't actually connect to HSA;
  2. @eddierichter-amd's add_one_dispatch test, which does connect to HSA.

Since the base branch is amd-staging, and not all of @atgutier's commits have landed there yet, add_one_dispatch currently fails (well XFAILs). I haven't tried it yet, but I believe on #14 it will pass - I haven't tried it because while you can run CI for PRs to the default branch (amd-staging) that introduce a new action/workflow, you cannot run CI for PRs to other branches until the action/workflow has landed in the default branch.

I'm skipping the line for this one ("force merging") for the sake of having some tests (and because it's a long weekend) but from now on all PRs will require review (including for myself and other admins).

FYI this same workflow can be used to cut a "release" that gets deposited at https://github.com/nod-ai/ROCR-Runtime/releases/tag/latest

cc @MaheshRavishankar @jtuyls @kumardeepakamd

@makslevental makslevental force-pushed the makslevental/aie-tests branch 30 times, most recently from 878904a to de7048c Compare August 30, 2024 20:43
@makslevental makslevental force-pushed the makslevental/aie-tests branch 7 times, most recently from 0dbcf64 to 0a42b0a Compare August 30, 2024 22:04
@makslevental makslevental force-pushed the makslevental/aie-tests branch from 0a42b0a to 9191877 Compare August 30, 2024 22:14
@makslevental makslevental changed the title [WIP] AIE CI tests [NO MERGE] AIE CI tests Aug 30, 2024
@makslevental makslevental force-pushed the makslevental/aie-tests branch 13 times, most recently from fc1b3fc to 1aa93eb Compare August 31, 2024 00:48
@makslevental makslevental force-pushed the makslevental/aie-tests branch from 1aa93eb to 127c9a5 Compare August 31, 2024 00:52
@makslevental makslevental changed the title [NO MERGE] AIE CI tests AIE CI tests Aug 31, 2024
@makslevental makslevental merged commit 7697356 into amd-staging Aug 31, 2024
3 checks passed
@makslevental makslevental deleted the makslevental/aie-tests branch August 31, 2024 01:00
makslevental added a commit that referenced this pull request Aug 31, 2024
Copy link
Collaborator

@atgutier atgutier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants