-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
packer-rocm/repos: +dir for overrides, bool for GA-optout #59
Conversation
I was able to craft an image with a test Holding for one more change: configurable package name for |
Can specify the build number; built/deployed an image with a release published to a private repository, selected from three weeks ago. Now testing the conventional/unspecified case for regression. Should still be able to produce GA images with no variables or custom repositories. |
Testing looks good; with no repository override or changes to the amdgpu/rocm package requests, the GA driver was pulled: ~/ADA $ tar xvf packer-rocm/packer-maas/ubuntu/ubuntu-rocm.tar.gz ./var/lib/dpkg/info/amdgpu-dkms.list ./var/lib/dpkg/info/amdgpu-core.md5sums
./var/lib/dpkg/info/amdgpu-dkms.list
./var/lib/dpkg/info/amdgpu-core.md5sums
~/ADA $ grep -m3 src ./var/lib/dpkg/info/amdgpu-dkms.list
/usr/src
/usr/src/amdgpu-6.8.5-2044426.22.04
/usr/src/amdgpu-6.8.5-2044426.22.04/amd Can be merged as-is, letting this sit for a moment longer in case inspiration hits. Outside review/suggestion is welcome edit: inspiration landed - locking this in to start working on the next effort: package requirements being renamed. Not yet clear to which releases this will apply |
It may be preferable to add more repositories to the image. Not just for certain
amdgpu
orROCm
releases... but any software at all.To that end, introduce the
repositories
directory. Any.repo
or.list
files that apply for the given OS family will be copied to the builder VM. Example:For the specific
amdgpu
/ROCm use-case, therocm_repos
variable has been introduced. This may be used to opt out of the GA repositories atrepo.radeon.com
.