Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packer-rocm/repos: +dir for overrides, bool for GA-optout #59

Merged
merged 9 commits into from
Oct 24, 2024

Conversation

joshlay2amd
Copy link
Collaborator

@joshlay2amd joshlay2amd commented Oct 24, 2024

It may be preferable to add more repositories to the image. Not just for certain amdgpu or ROCm releases... but any software at all.

To that end, introduce the repositories directory. Any .repo or .list files that apply for the given OS family will be copied to the builder VM. Example:

# file: ADA/packer-rocm/repositories/amdgpu.list
deb [ trusted=yes ] http://artifactory.domain.tld/artifactory/list/repository-name/ jammy/6.3 amdgpu-pro

For the specific amdgpu/ROCm use-case, the rocm_repos variable has been introduced. This may be used to opt out of the GA repositories at repo.radeon.com.

@joshlay2amd joshlay2amd marked this pull request as draft October 24, 2024 01:09
@joshlay2amd
Copy link
Collaborator Author

joshlay2amd commented Oct 24, 2024

I was able to craft an image with a test amdgpu release from another repository. Looks good.

Holding for one more change: configurable package name for amdgpu. Will allow - but not require - specifying the build number

@joshlay2amd
Copy link
Collaborator Author

joshlay2amd commented Oct 24, 2024

Can specify the build number; built/deployed an image with a release published to a private repository, selected from three weeks ago.

Now testing the conventional/unspecified case for regression. Should still be able to produce GA images with no variables or custom repositories.

@joshlay2amd joshlay2amd marked this pull request as ready for review October 24, 2024 17:27
@joshlay2amd
Copy link
Collaborator Author

joshlay2amd commented Oct 24, 2024

Testing looks good; with no repository override or changes to the amdgpu/rocm package requests, the GA driver was pulled:

~/ADA $ tar xvf packer-rocm/packer-maas/ubuntu/ubuntu-rocm.tar.gz ./var/lib/dpkg/info/amdgpu-dkms.list ./var/lib/dpkg/info/amdgpu-core.md5sums
./var/lib/dpkg/info/amdgpu-dkms.list
./var/lib/dpkg/info/amdgpu-core.md5sums
~/ADA $ grep -m3 src ./var/lib/dpkg/info/amdgpu-dkms.list
/usr/src
/usr/src/amdgpu-6.8.5-2044426.22.04
/usr/src/amdgpu-6.8.5-2044426.22.04/amd

Can be merged as-is, letting this sit for a moment longer in case inspiration hits. Outside review/suggestion is welcome

edit: inspiration landed - locking this in to start working on the next effort: package requirements being renamed. Not yet clear to which releases this will apply

@joshlay2amd joshlay2amd merged commit b1791e4 into main Oct 24, 2024
2 checks passed
@joshlay2amd joshlay2amd deleted the packer-rocm-repooverride branch October 24, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant