feat: error handling for missing location

app/facades/road_trip_facade.rb

@@ -1,13 +1,17 @@
 class RoadTripFacade
   def new_trip(params)
-    trip = MapquestService.new.trip(params[:origin], params[:destination])
+    if (params[:origin] != "") && (params[:destination] != "")
+      trip = MapquestService.new.trip(params[:origin], params[:destination])
 
-    if trip.nil?
-      impossible_trip_response(params[:origin], params[:destination])
+      if trip.nil?
+        impossible_trip_response(params[:origin], params[:destination])
+      else
+        weather = WeatherFacade.new.get_weather(params[:destination])
+        weather_on_arrival = weather.future_weather(trip.time)
+        RoadTripSerializer.new(trip, weather_on_arrival).serialize_json
+      end
     else
-      weather = WeatherFacade.new.get_weather(params[:destination])
-      weather_on_arrival = weather.future_weather(trip.time)
-      RoadTripSerializer.new(trip, weather_on_arrival).serialize_json
+      ErrorSerializer.new(ErrorMessage.new("Must Provide Location", 404))
     end
   end
 

spec/requests/api/v1/road_trip_request_spec.rb

@@ -107,5 +107,25 @@
 
       expect(response).to be_successful
     end
+
+    it 'requires user to provide a location', :vcr do
+      user1 = User.create!(email: '[email protected]', password: 'password', password_confirmation: 'password', api_key: SecureRandom.hex)
+      road_trip_body = {
+        origin: "New York,NY",
+        destination: "",
+        api_key: user1.api_key
+      }
+      post '/api/v1/road_trip', params: road_trip_body
+
+      json_response = JSON.parse(response.body, symbolize_names: true)
+      expect(json_response).to eq(
+        {
+            "error": {
+                "message": "Must Provide Location",
+                "status": 404
+            }
+        }
+      )
+    end
   end
 end