Skip to content

Commit

Permalink
actions: Remove lint (#1040)
Browse files Browse the repository at this point in the history
We have found weird issues with the actions and the feature it has of
showing the line at the code review is not used much. This change
move the lint to "check" target so it's run as part of prow unit-test.

Signed-off-by: Enrique Llorente <[email protected]>
  • Loading branch information
qinqon authored Apr 7, 2022
1 parent 6c8c3f1 commit 3699213
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 26 deletions.
22 changes: 0 additions & 22 deletions .github/workflows/check.yaml

This file was deleted.

2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ SKIP_IMAGE_BUILD ?= false

all: check handler

check: vet whitespace-check gofmt-check
check: lint vet whitespace-check gofmt-check

format: whitespace-format gofmt

Expand Down
6 changes: 3 additions & 3 deletions hack/lint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ golangci_lint_version=v1.42.1
if [ ! -f $(go env GOPATH)/bin/golangci-lint ]; then
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin $golangci_lint_version
fi
golangci-lint run
golangci-lint run --timeout 5m0s
(
cd api
golangci-lint run --config ../.golangci.yml
)
golangci-lint run --timeout 5m0s --config ../.golangci.yml
)

0 comments on commit 3699213

Please sign in to comment.