Feature/progress callback (thread safe.)#108
Open
westnt wants to merge 26 commits intonmmapper:mainfrom
Open
Conversation
…eference to self.xml_path. implemented io from xml_path file
…out is used for status and xml is written to disk.
…back to more functions.
Author
|
Adding multi-threading should be fine and not cause any issues. In fact, the old code here is a snip-it from the subprocess module code for reference: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This time the implementation is cleaner, doesn't have the terminal cleanup code, and is thread safe.
Summary:
Added support for real-time progress reporting in Nmap scans via a progress_callback parameter.
Motivation:
Usage Example:
Changes:
Testing:
Code was tested with file:
test.py