Remove (incorrect) unused ?Sized bound
#8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This crate may break in rust-lang/rust#123531.
The
K: ?Sizedbound is unused by any of the code in the library, and also isn't even theoretically able to be used either (Rust only allows the last field of a tuple to be unsized).The Rust compiler wasn't checking the validity of closure arguments before rust-lang/rust#123531 -- therefore it didn't see that the argument
&(K, V)was invalid in the closure being returned byequivalent_key, since Rust requiresKto beSizedin order to be in the non-final position of a tuple.